chore(browser): Remove debug config from tests#20600
Merged
Conversation
This lead to hard to read logs, as this enables the debugger which leaks into other tests as well etc.
JPeer264
approved these changes
Apr 29, 2026
JPeer264
reviewed
Apr 29, 2026
|
|
||
| Sentry.init({ | ||
| ...getBaseOptionsForTraceLifecycle(send), | ||
| debug: true, |
Member
There was a problem hiding this comment.
Best would be that debug would be enabled when we rerun the CI with the debug options enabled. But there is no documentation anywhere if a env variable is set when this is activated.
Contributor
size-limit report 📦
|
logaretm
approved these changes
Apr 29, 2026
Member
|
Don't think we need debug on the CI anyways, if a test fails we try to run it locally and from there we can debug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lead to hard to read logs, as this enables the debugger which leaks into other tests as well etc.