Skip to content

fix(core): Avoid parse-time SyntaxError on Safari <16.4 in postgresjs #20498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
logaretm merged 3 commits into from
Apr 27, 2026
+10 −1
Merged

fix(core): Avoid parse-time SyntaxError on Safari <16.4 in postgresjs #20498

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72afd61
fix(core): Avoid parse-time SyntaxError on Safari <16.4 in postgresjs
logaretm Apr 24, 2026
9f8d834
refactor(core): Lazy-init integer literal regex
logaretm Apr 24, 2026
e25324c
refactor(core): Use if-guard instead of ??= for regex lazy init
logaretm Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/core/src/integrations/postgresjs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,10 @@ export function _sanitizeSqlQuery(sqlQuery: string | undefined): string {
.replace(/-?\b\d+\.?\d*[eE][+-]?\d+\b/g, '?') // Scientific notation
.replace(/-?\b\d+\.\d+\b/g, '?') // Decimals
.replace(/-?\.\d+\b/g, '?') // Decimals starting with dot
.replace(/(?<!\$)-?\b\d+\b/g, '?') // Integers (NOT $n placeholders)
// Constructed via `new RegExp` so the negative lookbehind is evaluated at
// runtime. As a literal, it is a parse-time SyntaxError on Safari <16.4 —
// which breaks any browser bundle that reaches this module via the core barrel.
.replace(new RegExp('(?<!\\$)-?\\b\\d+\\b', 'g'), '?') // Integers (NOT $n placeholders)
Comment thread
logaretm marked this conversation as resolved.
Outdated
Comment thread
logaretm marked this conversation as resolved.
Outdated
// Collapse IN clauses for cardinality (both ? and $n variants)
.replace(/\bIN\b\s*\(\s*\?(?:\s*,\s*\?)*\s*\)/gi, 'IN (?)')
.replace(/\bIN\b\s*\(\s*\$\d+(?:\s*,\s*\$\d+)*\s*\)/gi, 'IN ($?)')
Expand Down
Loading