Conversation
Carry forward the binding and external fixture fixes from PR #16765. Fail external tests when every configured install command fails and cover the install-command behavior with focused tests. Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
Replace the standalone Cargo cooldown gate with first-step secure-runner and its shared Bash wrappers and internal-error guard. Preserve normal CI matrices, Depot runners, caches, and publication guards. Pin trusted prebuilt installers, repair the Windows Taiki path, and retain explicit platform endpoint settings. Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
Contributor
|
Temporarily run the push test matrix and require the macOS Touch ID job on PRs. Keep this coverage expansion isolated for later reversion; publishing guards and dependency caches are unchanged. Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
Preserve the new LCOV report checks after the relocated Linux dependencies. Retain shared Socket interception, the full test matrix and required Touch ID coverage. Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
Resolve the selected toolchain executable instead of assuming Cargo lives under CARGO_HOME. Expose its directory only for the prebuilt Taiki installer; subsequent Bash steps restore Socket interception. Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
Match the compiler-host platform split for the 12 test RPC hosts: wrap on Linux and bypass inspection on macOS/Windows. This addresses the observed macOS UnknownIssuer failures while retaining normal TLS verification and package registry screening. Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
decofe
force-pushed
the
centaur/shared-socket-ci-1789281588
branch
from
September 13, 2026 12:27
fe3c816 to
eca39bf
Compare
Temporarily capture debug output and the JSON report from the MPP build to investigate repeated download terminations. Upload sanitized diagnostics even on failure without changing the build command, runner, routing, or Socket failure guard. Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
Fetch the locked workspace dependencies before the MPP build to determine whether Socket terminates without any compilation. Preserve the shared wrapper, failure guard, runner, routing, and build command; collect separate fetch and build diagnostics even on failure. Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
Add temporary MPP fetch-only comparison jobs for the original and current secure-runner pins. Use identical pinned Rust, runner type, routing, and empty Cargo caches; retain failure detection and upload separate sanitized evidence without changing the existing MPP test job. Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
Compare the isolated MPP dependency fetch on Depot and GitHub-hosted Ubuntu with the same current secure-runner pin, Rust version, routing, and empty Cargo caches. Preserve failure checks and separate diagnostic artifacts; leave the MPP build and other workflows unchanged. Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
Restore the exact tree from 9a55235, before the TLS-routing experiment. Remove temporary Socket diagnostics, isolated fetching, runner comparisons, and artifact uploads while preserving commit history. Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
Merge the latest master changes, preserving Socket interception and pinned tool installs while retaining updated installer action references and the rustls security fix. Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the standalone Cargo cooldown gate with first-step
secure-runner, using the automatic Bash interception and shared Socket-error guard from tempoxyz/gh-actions#156. Keep Depot runners, caches and normal PR coverage; pin prebuilt tools and preserve the platform compatibility fixes.Carry forward the generated binding lockfiles, frozen fixture installs and installation-failure checks from #16765, without its temporary full-matrix expansion or duplicated Socket checks. Cached packages, trusted bootstrap downloads and container-internal installs are not covered by host interception; Bun and nested installer coverage still need validation.
Requires merging the shared-action PR and repinning before merge. CI/test-only change: a maintainer should apply
L-ignore.Code and PR text were written with AI assistance.
Prompted by: @grandizzy