Conversation
kriss39
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse and
stevencartavia
as code owners
September 11, 2026 22:57
Contributor
✅ Changelog foundThe deterministic check will validate the changed entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The foundryup bootstrap currently uses the same cleanup trap for EXIT, SIGINT, and SIGTERM. Because the cleanup handler returns successfully, cancelling the bootstrap can clean up the temp files and then continue running instead of stopping.
This changes signal handling so SIGINT exits with 130 and SIGTERM exits with 143, while the EXIT trap still handles cleanup. That keeps the existing launcher untouched when the bootstrap is interrupted.
I also added regression tests for both signals to make sure the bootstrap exits with the expected status, does not replace the launcher, and does not reach the final exec.
This was introduced as part of the Rust foundryup migration in #15498.