Conversation
Import the Solar VS Code and Zed clients with their grammar resources, licenses and source attribution. Use one resolved Forge executable for forge lsp, formatting and automatic Forge checks, preserving existing settings and command identifiers with explicit executable-path migration. Add isolated development hosts, independent client builds and CI, local packaging instructions and real Forge regression coverage for unsaved diagnostics, navigation and project-aware formatting. Developed with AI assistance for implementation, tests and documentation.
0xKarl98
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse and
stevencartavia
as code owners
September 8, 2026 08:06
Contributor
✅ Changelog foundThe deterministic check will validate the changed entry. |
0xKarl98
marked this pull request as draft
September 8, 2026 08:08
0xKarl98
marked this pull request as ready for review
September 8, 2026 08:29
mattsse
requested changes
Sep 8, 2026
mablr
reviewed
Sep 8, 2026
Member
|
please symlink the licenses from root dir not copy, and delete the dist dirs |
The LSP server can close its output after exit before the test client enqueues its local Stop event, making successful shutdown panic with ServiceStopped. Remove the redundant event and wait for EOF while retaining protocol error and child exit-status checks.
DaniPopes
added a commit
to paradigmxyz/solar
that referenced
this pull request
Sep 8, 2026
Foundry PR #16730 moves the VS Code and Zed clients into Foundry and makes `forge lsp` the editor entry point. Remove the duplicated clients from Solar so there is one maintained implementation and keep the Solar LSP server that Foundry embeds. This removes the tracked VS Code and Zed client sources, grammar assets, package metadata, and the VS Code Dependabot update block. It keeps `editors/README.md` as a migration page for existing links, updates the root README to point users to Foundry, and removes stale workspace links to the deleted Zed crate. Historical changelog entries remain unchanged. The Solar `crates/lsp` implementation, CLI entry point, tests, and benchmarks are untouched. Related: foundry-rs/foundry#16730 --------- Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forge already embeds the Solar language server. This PR adds the editor clients and lets users open VS Code directly with
forge lsp.forge lspin a terminal from any Solidity project directory to open that project in a VS Code Extension Development Host. Open a.solfile to get diagnostics, Go to Definition, hover and formatting.editors/so they can be maintained alongside Forge. Both use the same selected Forge executable for the language server, formatting and background checks. Keep the original licenses, attribution and command IDs, and provide migration messages for settings that previously selected standalone Solar.forge lsp --stdioas the server entry point for editor clients. Bareforge lspalso stays in server mode when stdin is redirected;--vscodeexplicitly opens VS Code.For a user with this build installed, the starting point is their own project:
cd /path/to/solidity-project forge lsp