-
Notifications
You must be signed in to change notification settings - Fork 54
[AI] ImageConfig and FinishReasons #1422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
paulb777
wants to merge
10
commits into
main
Choose a base branch
from
pb-nanobanana-image-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
859c306
[AI] Add ImageConfig and expand FinishReasons
paulb777 d9fc1c4
feat(ai): refactor ImageConfig to use structs for custom values in Unity
paulb777 9c2bbda
Merge branch 'main' into pb-nanobanana-image-config
paulb777 2d15f58
feat(ai): implement IEquatable and add null checks in ImageConfig in …
paulb777 d912206
Address code review: simplify null-handling and property access
paulb777 abd33ab
Merge branch 'main' into pb-nanobanana-image-config
a-maurice b97b12f
Fix compile issues, and slight refactor
a-maurice f21c220
Merge branch 'main' into pb-nanobanana-image-config
a-maurice 61e1152
Update readme.md
a-maurice 89f5e8d
Move ImageConfig into GenConfig file
a-maurice File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| /* | ||
| * Copyright 2026 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| using System.Collections.Generic; | ||
|
|
||
| namespace Firebase.AI | ||
| { | ||
| /// <summary> | ||
| /// Configuration options for generating images with Gemini models. | ||
| /// </summary> | ||
| public readonly struct ImageConfig | ||
| { | ||
| /// <summary> | ||
| /// The aspect ratio of generated images. | ||
| /// </summary> | ||
| public enum AspectRatio | ||
| { | ||
| Square1x1, | ||
| Portrait9x16, | ||
| Landscape16x9, | ||
| Portrait3x4, | ||
| Landscape4x3, | ||
| Portrait2x3, | ||
| Landscape3x2, | ||
| Portrait4x5, | ||
| Landscape5x4, | ||
| Portrait1x4, | ||
| Landscape4x1, | ||
| Portrait1x8, | ||
| Landscape8x1, | ||
| Ultrawide21x9 | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// The size of images to generate. | ||
| /// </summary> | ||
| public enum ImageSize | ||
| { | ||
| Size512, | ||
| Size1K, | ||
| Size2K, | ||
| Size4K | ||
| } | ||
|
|
||
| public AspectRatio? Ratio { get; } | ||
| public ImageSize? Size { get; } | ||
|
|
||
| public ImageConfig(AspectRatio? aspectRatio = null, ImageSize? imageSize = null) | ||
| { | ||
| Ratio = aspectRatio; | ||
| Size = imageSize; | ||
| } | ||
|
|
||
| internal static string ConvertAspectRatio(AspectRatio aspectRatio) | ||
| { | ||
| return aspectRatio switch | ||
| { | ||
| AspectRatio.Square1x1 => "1:1", | ||
| AspectRatio.Portrait9x16 => "9:16", | ||
| AspectRatio.Landscape16x9 => "16:9", | ||
| AspectRatio.Portrait3x4 => "3:4", | ||
| AspectRatio.Landscape4x3 => "4:3", | ||
| AspectRatio.Portrait2x3 => "2:3", | ||
| AspectRatio.Landscape3x2 => "3:2", | ||
| AspectRatio.Portrait4x5 => "4:5", | ||
| AspectRatio.Landscape5x4 => "5:4", | ||
| AspectRatio.Portrait1x4 => "1:4", | ||
| AspectRatio.Landscape4x1 => "4:1", | ||
| AspectRatio.Portrait1x8 => "1:8", | ||
| AspectRatio.Landscape8x1 => "8:1", | ||
| AspectRatio.Ultrawide21x9 => "21:9", | ||
| _ => aspectRatio.ToString(), | ||
|
paulb777 marked this conversation as resolved.
Outdated
|
||
| }; | ||
| } | ||
|
|
||
| internal static string ConvertImageSize(ImageSize imageSize) | ||
| { | ||
| return imageSize switch | ||
| { | ||
| ImageSize.Size512 => "512", | ||
| ImageSize.Size1K => "1K", | ||
| ImageSize.Size2K => "2K", | ||
| ImageSize.Size4K => "4K", | ||
| _ => imageSize.ToString(), | ||
|
paulb777 marked this conversation as resolved.
Outdated
|
||
| }; | ||
| } | ||
|
|
||
| internal Dictionary<string, object> ToJson() | ||
| { | ||
| Dictionary<string, object> jsonDict = new(); | ||
| if (Ratio.HasValue) jsonDict["aspectRatio"] = ConvertAspectRatio(Ratio.Value); | ||
| if (Size.HasValue) jsonDict["imageSize"] = ConvertImageSize(Size.Value); | ||
| return jsonDict; | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.