fix(openapi): support untyped oneOf query properties - #945
Open
lprnmns wants to merge 1 commit into
Open
Conversation
Signed-off-by: lprnmns <manasalperen@gmail.com>
lprnmns
marked this pull request as ready for review
August 31, 2026 16:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a query schema uses oneOf branches with properties but no explicit type, the generated OpenAPI document treats the literal properties object as a query parameter. For the current reproduction from #633, this produces an invalid parameter and Swagger/OpenAPI validation fails.
Fix
Allow the existing local-parameter resolver to expand schemas based on properties without requiring an explicit type. Explicitly typed schemas retain their existing behavior; untyped object branches now generate the intended query parameters.
Tests
Compatibility
This is a narrow compatibility fix for valid JSON Schema object branches that omit type. Existing schemas with an explicit type follow the same code path; the change adds no public option, dependency, or version change.
Related issue
Fixes #633
Checklist