Skip to content

Remove unused ExpandRowRecursive after #305 #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 1 commit into from
May 3, 2026
Merged

Remove unused ExpandRowRecursive after #305 #306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions src/PlanViewer.App/Controls/QueryStoreGridControl.axaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,10 @@
using System.Linq;
using System.Runtime.CompilerServices;
using System.Threading;
using Avalonia;
using Avalonia.Controls;
using Avalonia.Controls.Primitives;
using Avalonia.Interactivity;
using Avalonia.Media;
using Microsoft.Data.SqlClient;
using PlanViewer.Core.Interfaces;
using PlanViewer.Core.Models;
using PlanViewer.App.Dialogs;
Expand Down Expand Up @@ -312,8 +310,6 @@ private async System.Threading.Tasks.Task FetchGroupedPlansAsync(
LoadButton.IsEnabled = true;
SelectToggleButton.Content = "Select All";



UpdateStatusText();
UpdateBarRatios();

Expand All @@ -322,29 +318,6 @@ private async System.Threading.Tasks.Task FetchGroupedPlansAsync(
_ = FetchGroupedWaitStatsAsync(_slicerStartUtc.Value, _slicerEndUtc.Value, ct);
}

/// <summary>
/// Recursively expands a row and all its children, inserting them into _filteredRows.
/// </summary>
private void ExpandRowRecursive(QueryStoreRow row)
{
if (!row.HasChildren) return;
row.IsExpanded = true;

var idx = _filteredRows.IndexOf(row);
if (idx < 0) return;

var insertAt = idx + 1;
foreach (var child in row.Children)
{
_filteredRows.Insert(insertAt, child);
insertAt++;
}

// Recurse into each child that has children
foreach (var child in row.Children)
ExpandRowRecursive(child);
}

/// <summary>
/// Fetches per-plan wait stats for all real plan IDs found in the grouped hierarchy,
/// assigns them to leaf rows, then consolidates upward to intermediate and root rows.
Expand Down
Loading