Rule 38: suppress when query has explicit MAXDOP 2 hint#304
Merged
erikdarlingdata merged 1 commit intodevfrom May 2, 2026
Merged
Rule 38: suppress when query has explicit MAXDOP 2 hint#304erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
When the user explicitly sets OPTION (MAXDOP 2) in the query, the DOP cap is intentional and not the SQL Server Standard Edition batch-mode limitation, so the warning would be misleading. Suppress in that case (both the Standard-Edition-confirmed Warning path and the unknown-edition Info path). Mirrors the existing Rule 3 (Serial Plan) handling for MAXDOP 1 hints. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #275 (Standard Edition DOP 2 limitation rule).
When the user explicitly sets
OPTION (MAXDOP 2)in a query, observing DOP=2 + batch mode operators is just the user's hint doing what was asked — not the Standard Edition batch-mode cap. The warning would be misleading in that case, so suppress it.Mirrors the same handling Rule 3 (Serial Plan) uses for explicit
MAXDOP 1hints.Behavior
OPTION (MAXDOP 2)(or any case-insensitive `MAXDOP 2` token) inStatementText: no warning, regardless of edition.Test plan
dotnet test— 77/77 pass (5 pre-existing Rule 38 tests + 2 new)Rule38_StandardEdition_Dop2_BatchMode_MaxDop2QueryHint_NoWarningRule38_NoServerMetadata_Dop2_BatchMode_MaxDop2QueryHint_NoWarningdotnet buildCore + Web — clean