Split FinOps services and content code-behinds into partial classes#913
Merged
erikdarlingdata merged 2 commits intodevfrom Apr 29, 2026
Merged
Split FinOps services and content code-behinds into partial classes#913erikdarlingdata merged 2 commits intodevfrom
erikdarlingdata merged 2 commits intodevfrom
Conversation
Move-only refactor; no behavior changes. Five files split: Services (partials of partials): - Dashboard/Services/DatabaseService.FinOps.cs (2924 → 24) into 7 sub-partials: Inventory, Workload, Storage, Queries, IndexAnalysis, Recommendations, Models - Lite/Services/LocalDataService.FinOps.cs (2702 → 525) into 7 sub-partials: ServerProperties, Inventory, StorageGrowth, Utilization, Workload, IndexAnalysis, Recommendations Content code-behinds (per-tab partials): - Dashboard/Controls/SystemEventsContent.xaml.cs (2263 → 363) into 10 partials: FilterPopup, SystemHealth, SevereErrors, IOIssues, SchedulerIssues, MemoryConditions, CPUTasks, MemoryBroker, MemoryNodeOOM, CopyExport - Dashboard/Controls/ResourceMetricsContent.xaml.cs (1881 → 406) into 8 partials: LatchStats, SpinlockStats, TempdbStats, SessionStats, FileIoLatency, PerfmonCounters, WaitStatsDetail, CopyExport - Dashboard/Controls/MemoryContent.xaml.cs (1356 → 256) into 6 partials: MemoryStats, MemoryGrants, MemoryClerks, PlanCache, MemoryPressure, CopyExport Build: 0 errors. Smoke-tested: 30-min Lite watch with 0 error events; collection_health snapshot 18,390 runs across 24 collectors, 100% SUCCESS. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The fix in 562269f added IsTrayToolTipCrash() to OnDispatcherUnhandledException in both apps, but the same race in Hardcodet.NotifyIcon.Wpf can also escape to OnUnhandledException (AppDomain) — observed today when exiting via the tray context menu. The Dispatcher's exception hooks tear down before the tray library finishes processing late tooltip-hide messages, so the exception arrives at AppDomain with no suppression and the user sees a Fatal Error dialog despite the underlying crash being harmless. Mirror the same IsTrayToolTipCrash() check in OnUnhandledException for both Lite and Dashboard. Logs a Warn and returns without showing the dialog. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lite/andDashboard/into focused partial-class siblings. No behavior or signature changes. Continuation of Split Lite + Dashboard god-class files into partial classes #912.Services (sub-partials of an existing partial — same pattern as PR #912's
DatabaseService.QueryPerformancesplit):Dashboard/Services/DatabaseService.FinOps.cs: 2,924 → 24 (7 sub-partials)Lite/Services/LocalDataService.FinOps.cs: 2,702 → 525 (7 sub-partials)Content code-behinds (per-tab partials):
Dashboard/Controls/SystemEventsContent.xaml.cs: 2,263 → 363 (10 partials)Dashboard/Controls/ResourceMetricsContent.xaml.cs: 1,881 → 406 (8 partials)Dashboard/Controls/MemoryContent.xaml.cs: 1,356 → 256 (6 partials)Test plan
dotnet build Lite/PerformanceMonitorLite.csproj -c Debug— 0 errorsdotnet build Dashboard/Dashboard.csproj -c Debug— 0 errors🤖 Generated with Claude Code