sp_IndexCleanup: expand adversarial tests to 26 assertions + heap fix#731
Merged
erikdarlingdata merged 1 commit intodevfrom Mar 26, 2026
Merged
sp_IndexCleanup: expand adversarial tests to 26 assertions + heap fix#731erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
New test groups: - Group 8: Exact duplicates (same keys + same includes) - Group 9: Reverse column order (different leading col — by design NOT flagged) - Group 10: Equal except filter (filtered vs unfiltered — NOT duplicates) - Group 11: UC Replacement (Rule 7/7.5 — UC dropped, NC gets MAKE UNIQUE) - Group 12: Rule interactions (multi-level subset A ⊂ AB ⊂ ABC) Known issue #730: UC with both subset and exact-match NC on same table — indexes don't appear in output. Skipped in test suite pending investigation. Also includes heap fix (#727) and UNIQUE merge script fix (#724). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expands the adversarial test suite from 18 to 26 assertions covering:
Includes heap fix (#727) and UNIQUE merge script fix (#724).
Known issue filed as #730 (UC with subset + exact-match NC interaction).
26/26 passing.
🤖 Generated with Claude Code