sp_IndexCleanup: fix heap table index detection (#727)#729
Merged
erikdarlingdata merged 1 commit intodevfrom Mar 26, 2026
Merged
sp_IndexCleanup: fix heap table index detection (#727)#729erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
The partition stats row count filter used ps.index_id = 1 which only matches clustered indexes. Heaps use index_id = 0, so heap tables were excluded entirely from deduplication analysis. Changed to ps.index_id IN (0, 1) to include both heaps and clustered. Closes #727 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changed
ps.index_id = 1tops.index_id IN (0, 1)in the partition stats row count filter so heap tables (index_id = 0) are included in deduplication analysis.Adversarial test suite: 18/18 passing.
Closes #727
🤖 Generated with Claude Code