sp_IndexCleanup: preserve UNIQUE in merge script (#724)#725
Merged
erikdarlingdata merged 3 commits intodevfrom Mar 26, 2026
Merged
sp_IndexCleanup: preserve UNIQUE in merge script (#724)#725erikdarlingdata merged 3 commits intodevfrom
erikdarlingdata merged 3 commits intodevfrom
Conversation
sp_IndexCleanup: performance + bug fix #721
…onstraints (#724) The merge script generator only checked for action = 'MAKE UNIQUE' when deciding whether to include UNIQUE in CREATE INDEX. When a unique constraint/index was the Key Superset target (action = 'MERGE INCLUDES'), the generated script dropped the UNIQUE keyword. Now checks is_unique directly on the index being scripted. Tested with both unique constraints and unique indexes on SQL2022. Closes #724 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merge scripts for Key Superset indexes now preserve the UNIQUE keyword when the index is unique. Previously only checked for the
MAKE UNIQUEaction, missing the case where a unique constraint/index was the superset target withMERGE INCLUDESaction.Closes #724
Test plan
CREATE UNIQUE INDEXCREATE UNIQUE INDEXCREATE INDEX(no change)🤖 Generated with Claude Code