Skip to content

Refine ANSI Settings Check Logic to Align with Modern Best Practices (Fixes #658)#659

Merged
erikdarlingdata merged 2 commits intoerikdarlingdata:devfrom
gflpcantor31:issue_658
Jan 19, 2026
Merged

Refine ANSI Settings Check Logic to Align with Modern Best Practices (Fixes #658)#659
erikdarlingdata merged 2 commits intoerikdarlingdata:devfrom
gflpcantor31:issue_658

Conversation

@gflpcantor31
Copy link
Copy Markdown
Contributor

Description :
Fixes #658
This PR updates the logic of the ANSI settings check (check_id 7005) to distinguish modern recommended best practices from legacy default behaviors.

✔️ What’s changed

  • Corrected the inverted/legacy leftover logic identified in Issue sp_PerfCheck : Improve ANSI Settings Check Logic to Distinguish Best Practices from Legacy Defaults #658.
  • Evaluates ANSI settings based on recommended ON/OFF values rather than historical defaults.
  • Preserves the original ordering of the settings to keep the diff minimal and maintain readability.
  • Improves the details message to clearly indicate which settings deviate from best practices.
  • Adds a concise concluding sentence explaining the potential impact of misconfigured ANSI settings.

✔️ Why this matters

The previous logic flagged settings based on outdated assumptions and did not reflect current SQL Server best practices.
This update ensures the check is accurate, actionable, and aligned with real-world usage.

✔️ Additional notes

Once merged, the explanatory page at:
https://erikdarling.com/sp_PerfCheck/#ANSISettings
may also need an update, as it still reflects the previous behavior (“non‑standard ANSI settings”).

If helpful, here is a suggested updated wording:
“Identifies ANSI settings that deviate from recommended best practices and may affect reliability or feature compatibility.”

@erikdarlingdata erikdarlingdata merged commit c13a5e2 into erikdarlingdata:dev Jan 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants