Refine ANSI Settings Check Logic to Align with Modern Best Practices (Fixes #658)#659
Merged
erikdarlingdata merged 2 commits intoerikdarlingdata:devfrom Jan 19, 2026
Merged
Conversation
…Legacy Defaults (issue erikdarlingdata#658)
…Legacy Defaults (issue erikdarlingdata#658)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description :
Fixes #658
This PR updates the logic of the ANSI settings check (check_id 7005) to distinguish modern recommended best practices from legacy default behaviors.
✔️ What’s changed
detailsmessage to clearly indicate which settings deviate from best practices.✔️ Why this matters
The previous logic flagged settings based on outdated assumptions and did not reflect current SQL Server best practices.
This update ensures the check is accurate, actionable, and aligned with real-world usage.
✔️ Additional notes
Once merged, the explanatory page at:
https://erikdarling.com/sp_PerfCheck/#ANSISettings
may also need an update, as it still reflects the previous behavior (“non‑standard ANSI settings”).
If helpful, here is a suggested updated wording:
“Identifies ANSI settings that deviate from recommended best practices and may affect reliability or feature compatibility.”