Skip to content

Dev #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 2 commits into from
Jun 5, 2025
Merged

Dev #626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0c2079
Update CLAUDE.md
erikdarlingdata Jun 1, 2025
85c0c15
Update sp_HumanEventsBlockViewer.sql
erikdarlingdata Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ This document outlines the T-SQL coding style preferences for Erik Darling (Darl

- **SELECT statements**:
- SELECT keyword on first line
- Column list starts on next line, indented
- Column list starts on next line, indented four spaces
- Trailing commas for multi-line column lists
- Columns aligned vertically for readability
- FROM clause on new line at same indent level as SELECT
Expand Down
10 changes: 5 additions & 5 deletions sp_HumanEvents/sp_HumanEventsBlockViewer.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ ALTER PROCEDURE
@log_schema_name sysname = NULL, /*schema to store logging tables*/
@log_table_name_prefix sysname = 'HumanEventsBlockViewer', /*prefix for all logging tables*/
@log_retention_days integer = 30, /*Number of days to keep logs, 0 = keep indefinitely*/
@max_blocking_events bigint = 5000, /*maximum blocking events to analyze, 0 = unlimited*/
@max_blocking_events integer = 5000, /*maximum blocking events to analyze, 0 = unlimited*/
@help bit = 0, /*get help with this procedure*/
@debug bit = 0, /*print dynamic sql and select temp table contents*/
@version varchar(30) = NULL OUTPUT, /*check the version number*/
Expand Down Expand Up @@ -156,7 +156,7 @@ BEGIN
WHEN N'@log_schema_name' THEN N'any valid schema name'
WHEN N'@log_table_name_prefix' THEN N'any valid identifier'
WHEN N'@log_retention_days' THEN N'a positive integer'
WHEN N'@max_blocking_events' THEN N'0 to 9223372036854775807 (0 = unlimited)'
WHEN N'@max_blocking_events' THEN N'0 to 2147483647 (0 = unlimited)'
WHEN N'@help' THEN '0 or 1'
WHEN N'@debug' THEN '0 or 1'
WHEN N'@version' THEN 'none; OUTPUT'
Expand Down Expand Up @@ -1148,7 +1148,7 @@ BEGIN
human_events_xml
FROM
(
SELECT TOP (CASE WHEN @max_blocking_events > 0 THEN @max_blocking_events ELSE 9223372036854775807 END)
SELECT TOP (CASE WHEN @max_blocking_events > 0 THEN @max_blocking_events ELSE 2147483647 END)
human_events_xml = e.x.query('.'),
event_timestamp = e.x.value('@timestamp', 'datetime2')
FROM #x AS x
Expand Down Expand Up @@ -1180,7 +1180,7 @@ BEGIN
human_events_xml
FROM
(
SELECT TOP (CASE WHEN @max_blocking_events > 0 THEN @max_blocking_events ELSE 9223372036854775807 END)
SELECT TOP (CASE WHEN @max_blocking_events > 0 THEN @max_blocking_events ELSE 2147483647 END)
human_events_xml = e.x.query('.'),
event_timestamp = e.x.value('@timestamp', 'datetime2')
FROM #x AS x
Expand Down Expand Up @@ -1241,7 +1241,7 @@ BEGIN
INTO #blocking_xml_sh
FROM
(
SELECT TOP (CASE WHEN @max_blocking_events > 0 THEN @max_blocking_events ELSE 9223372036854775807 END)
SELECT TOP (CASE WHEN @max_blocking_events > 0 THEN @max_blocking_events ELSE 2147483647 END)
event_time =
DATEADD
(
Expand Down