Prevent Duplicates In filtered_index_columns_analysis#559
Closed
bwiggin10 wants to merge 1 commit intoerikdarlingdata:mainfrom
bwiggin10:filtered_index_columns_analysis_PR
Closed
Prevent Duplicates In filtered_index_columns_analysis#559bwiggin10 wants to merge 1 commit intoerikdarlingdata:mainfrom bwiggin10:filtered_index_columns_analysis_PR
bwiggin10 wants to merge 1 commit intoerikdarlingdata:mainfrom
bwiggin10:filtered_index_columns_analysis_PR
Conversation
Owner
|
@bwiggins10 thanks, but the problem is that these tables weren't added to the truncate table list. Please read the contributing file though, I don't accept pull requests directly into main. |
Author
|
That's what I get for skimming - Thanks for the quick replies + fix |
Owner
|
@bwiggins10 No big deal at all! Thanks for helping out with this. New development like this is tough when you don't immediately have every edge case to test against! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the issue of duplicate values in #filtered_index_columns_analysis mentioned in #558 by preventing the insert into #filtered_index_columns_analysis from inserting values that already exist in the temp table.