support for granular subnet and tags#2538
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 96d37eb7e3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| network = var.network_name | ||
| nic_type = var.network_interface_type | ||
| network = var.network_name | ||
| subnetwork = var.subnetwork_name |
There was a problem hiding this comment.
subnetwork is now wired directly from var.subnetwork_name, but the new .env.gcp.template examples set subnetwork_name to ""; that propagates an explicit empty string into network_interface.subnetwork instead of omitting the field. In this configuration path (build/client cluster JSON overrides), Terraform will attempt to apply an empty subnetwork value rather than the previous default-network behavior, which can break applies for users who copy the template defaults. Convert empty strings to null before assigning subnetwork (as is already done for server/api/clickhouse/loki locals).
Useful? React with 👍 / 👎.
2 participants
We need to support granular subnets and tags, this pr allows those be configurable per mig so that each of them can be overridden