Skip to content

fix: replace O(n²) string concatenation in readLines with array buffering #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
beran-t wants to merge 2 commits into from
+32 −14

fix: replace O(n²) string concatenation in readLines with array buffe…

9d91e76
Select commit
Loading
Failed to load commit list.
Closed

fix: replace O(n²) string concatenation in readLines with array buffering #252

fix: replace O(n²) string concatenation in readLines with array buffe…
9d91e76
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Apr 14, 2026 in 9m 8s

Code review found 1 important issue

Found 4 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 1
🟡 Nit 0
🟣 Pre-existing 0
Severity File:Line Issue
🔴 Important js/src/utils.ts:34-38 Missing TextDecoder flush on stream end drops trailing multi-byte characters

Annotations

Check failure on line 38 in js/src/utils.ts

See this annotation in the file changed.

@claude claude / Claude Code Review

Missing TextDecoder flush on stream end drops trailing multi-byte characters 

The new code never flushes the TextDecoder before breaking on stream end, silently dropping any incomplete multi-byte UTF-8 sequences (e.g. a 4-byte emoji split across the final chunk). Fix: add `const trailing = decoder.decode(); if (trailing) pending.push(trailing)` before the `pending.length` check in the `done` branch.
View more details on Claude