Skip to content

Unify passing of template used in tests and log background commands output#704

Merged
ValentaTomas merged 17 commits intomainfrom
improve-js-tests
May 6, 2025
Merged

Unify passing of template used in tests and log background commands output#704
ValentaTomas merged 17 commits intomainfrom
improve-js-tests

Conversation

@ValentaTomas
Copy link
Copy Markdown
Member

@ValentaTomas ValentaTomas commented Apr 28, 2025 •
edited
Loading

  • Show errors from background commands
  • Unify passing of template used in tests

@ValentaTomas ValentaTomas added the Improvement Improvement for current functionality label Apr 28, 2025
@ValentaTomas ValentaTomas self-assigned this Apr 28, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 28, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: ead5d54

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

mishushakov
mishushakov reviewed Apr 28, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@mishushakov mishushakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, can you add also the changes to the py version? Should be in a similar manner

Comment thread packages/js-sdk/tests/sandbox/commands/run.test.ts
Comment thread packages/js-sdk/tests/sandbox/host.test.ts Outdated
Comment thread packages/js-sdk/tests/setup.ts
@mishushakov
Copy link
Copy Markdown
Member

mishushakov commented Apr 29, 2025

Python tests are erroring out with

e2b.exceptions.SandboxException: 500: error while getting template: Template not found

@ValentaTomas ValentaTomas enabled auto-merge (squash) May 2, 2025 13:19
jakubno
jakubno reviewed May 2, 2025
View reviewed changes
Comment thread packages/js-sdk/tests/cmdHelper.ts Outdated
Comment thread packages/python-sdk/tests/async/sandbox_async/commands/test_env_vars.py
Comment thread packages/python-sdk/tests/sync/sandbox_sync/commands/test_env_vars.py
Comment thread packages/python-sdk/tests/conftest.py Outdated
@ValentaTomas ValentaTomas requested a review from jakubno May 2, 2025 15:38
@ValentaTomas ValentaTomas merged commit 88266d6 into main May 6, 2025
5 checks passed
@ValentaTomas ValentaTomas deleted the improve-js-tests branch May 6, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakubno jakubno jakubno approved these changes

@mishushakov mishushakov Awaiting requested review from mishushakov mishushakov is a code owner

Assignees

@ValentaTomas ValentaTomas

Labels

Improvement Improvement for current functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ValentaTomas @mishushakov @jakubno