Add option for proxying SDK requests to API and sandbox#695
Merged
ValentaTomas merged 6 commits intomainfrom Apr 18, 2025
Merged
Add option for proxying SDK requests to API and sandbox#695ValentaTomas merged 6 commits intomainfrom
ValentaTomas merged 6 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 9fd8c87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ValentaTomas
added
feature
Contributor
|
at a glance this looks good, it's nice that we can leverage the |
0div
approved these changes
Apr 18, 2025
| :param debug: Enable debug mode, all requested are then sent to localhost | ||
| :param request_timeout: Timeout for the request in **seconds** | ||
| :param headers: Additional headers to send with the request | ||
| :param proxy: Proxy to use for the request |
Contributor
There was a problem hiding this comment.
i'd prob specify the type httpx.ProxyType here as the SDK ref won't show it explicitly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR that allows you to pass
proxy(of the type ProxyTypes) when calling methods in the SDK that send requests. Also, if you passproxywhen creating a sandbox, all the sandbox requests (called on the Sandbox/AsyncSandbox instance) will automatically use the same proxy.The PR also contains a small bugfix—adding missing passing of limits and passing these directly instead of through transport to be able to pass the proxy parameter properly.
This change should also be compatible with the code interpreter—it uses the client transport, which uses the passed proxy if there is any.