Skip to content

Flag for securing envd access with auth token - #688

Merged
sitole merged 40 commits into
mainfrom
api-support-for-start-sandbox-with-envd-auth-secret-e2b-1930
May 14, 2025
Merged

Flag for securing envd access with auth token#688
sitole merged 40 commits into
mainfrom
api-support-for-start-sandbox-with-envd-auth-secret-e2b-1930

Conversation

@sitole

@sitole sitole commented Apr 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Waiting until secure flag will be available in production cluster.

@sitole sitole added feature New feature or request python Pull requests that update Python code javascript Pull requests that update Javascript code labels Apr 17, 2025
@sitole sitole self-assigned this Apr 17, 2025
@linear

linear Bot commented Apr 17, 2025

Copy link
Copy Markdown

E2B-1930 API support for start sandbox with envd auth secret

@changeset-bot

changeset-bot Bot commented Apr 17, 2025 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 37b6d9c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@e2b/python-sdk Minor
e2b Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sitole
sitole force-pushed the api-support-for-start-sandbox-with-envd-auth-secret-e2b-1930 branch from 980beff to 9eb895b Compare April 17, 2025 15:15
@sitole
sitole force-pushed the api-support-for-start-sandbox-with-envd-auth-secret-e2b-1930 branch from db0f227 to a8fb49d Compare April 29, 2025 16:30
@sitole
sitole marked this pull request as ready for review April 30, 2025 09:51
mishushakov
mishushakov reviewed Apr 30, 2025
View reviewed changes

@mishushakov mishushakov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo

Comment thread packages/python-sdk/e2b/sandbox_sync/main.py Outdated
Comment thread packages/python-sdk/e2b/sandbox_sync/main.py Outdated
Comment thread packages/python-sdk/tests/sync/sandbox_sync/files/test_watch.py Outdated
Comment thread packages/python-sdk/tests/sync/sandbox_sync/files/test_write.py Outdated
Comment thread packages/python-sdk/tests/sync/sandbox_sync/test_connect.py Outdated
Comment thread packages/python-sdk/tests/sync/sandbox_sync/test_secure.py Outdated
@sitole
sitole requested a review from mishushakov April 30, 2025 20:02
@sitole
sitole force-pushed the api-support-for-start-sandbox-with-envd-auth-secret-e2b-1930 branch from 944fb2f to 7dfadbf Compare May 7, 2025 14:38
@sitole
sitole force-pushed the api-support-for-start-sandbox-with-envd-auth-secret-e2b-1930 branch from 92badc5 to d4d7afd Compare May 12, 2025 20:26
@sitole
sitole force-pushed the api-support-for-start-sandbox-with-envd-auth-secret-e2b-1930 branch from 792e94a to 4586040 Compare May 12, 2025 20:33
@sitole

sitole commented May 13, 2025

Copy link
Copy Markdown
Member Author

i meant

   self._envd_api = httpx.AsyncClient(
       base_url=self.envd_api_url,
       transport=self._transport,
       headers=self._connection_config.headers,
   )

added header into envd api client

jakubno
jakubno requested changes May 14, 2025
View reviewed changes

@jakubno jakubno left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the headers as we discuessed

Comment thread packages/python-sdk/e2b/sandbox/main.py Outdated
jakubno
jakubno reviewed May 14, 2025
View reviewed changes
Comment thread packages/js-sdk/src/sandbox/sandboxApi.ts
@sitole

sitole commented May 14, 2025

Copy link
Copy Markdown
Member Author

And the headers as we discussed

Okay, now injected directly into grpc pool

@sitole
sitole requested a review from jakubno May 14, 2025 12:37
jakubno
jakubno reviewed May 14, 2025
View reviewed changes

@jakubno jakubno left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And can we return name instead of alias as we are already doing elsewhere 🙏🏻

Comment thread packages/python-sdk/e2b/sandbox/sandbox_api.py Outdated
Comment thread packages/python-sdk/e2b/sandbox_async/filesystem/filesystem.py Outdated
Comment thread packages/python-sdk/e2b/sandbox_sync/filesystem/filesystem.py Outdated
jakubno
jakubno requested changes May 14, 2025
View reviewed changes
Comment thread packages/python-sdk/e2b/sandbox_sync/filesystem/filesystem.py Outdated
@sitole
sitole enabled auto-merge (squash) May 14, 2025 15:14
@sitole
sitole merged commit 2def130 into main May 14, 2025
@sitole
sitole deleted the api-support-for-start-sandbox-with-envd-auth-secret-e2b-1930 branch May 14, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakubno jakubno jakubno approved these changes
@ValentaTomas ValentaTomas Awaiting requested review from ValentaTomas
@mishushakov mishushakov Awaiting requested review from mishushakov mishushakov is a code owner

Assignees

@sitole sitole

Labels

feature New feature or request javascript Pull requests that update Javascript code python Pull requests that update Python code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sitole @mishushakov @jakubno