-
Notifications
You must be signed in to change notification settings - Fork 886
feat(sdk): support structured network rules with per-host transforms #1286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mishushakov
wants to merge
14
commits into
main
Choose a base branch
from
mishushakov/network-allowout-transform
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
85f8a45
feat(sdk): support structured network rules with per-host transforms
mishushakov 5229a6f
feat(python-sdk): support structured network rules and revert denyOut
mishushakov 6905b09
test(network): trim transform tests to a single allowOut entry
mishushakov 3600001
chore(python-sdk): hoist SandboxNetworkRule import in SandboxNetworkC…
mishushakov 92f4334
chore(python-sdk): drop unnecessary SandboxNetworkConfig alias
mishushakov 2f9ebbe
fix(python-sdk): preserve UNSET for SandboxNetworkConfig.allow_out
mishushakov 9b9eb89
fix(python-sdk): handle empty allow_out from generated client
mishushakov 3af584f
revert: keep isinstance(network.allow_out, Unset) check in from_clien…
mishushakov f867b9f
refactor(python-sdk): simplify allow_out conversion via to_dict()
mishushakov 6ade12c
refactor(sdk): split network policy and firewall transforms
mishushakov 99ab3e0
Merge branch 'main' into mishushakov/network-allowout-transform
mishushakov 5a5f885
refactor(sdk): nest firewall rules under network.rules
mishushakov f8ea7fa
feat(js-sdk): accept Map for network.rules
mishushakov 0653579
feat(sdk): add transform callback with placeholder context
mishushakov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JS SDK
SandboxMetricsmissing newmemCachefieldMedium Severity
The OpenAPI spec adds
memCacheas a required field onSandboxMetric(visible in the spec diff and in the generatedschema.gen.tsat line 2321), and the Python generated client (sandbox_metric.py) was updated accordingly. However, the JS SDK's hand-writtenSandboxMetricsinterface does not includememCache. Any metrics mapping code will silently drop this field, making it inaccessible to JS SDK consumers.Reviewed by Cursor Bugbot for commit f8ea7fa. Configure here.