Skip to content

Allow apt tests to fail #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mishushakov wants to merge 8 commits into from
Closed

Allow apt tests to fail #1115

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4fa98a2
allow apt tests to fail
mishushakov Feb 4, 2026
82d12a4
fix: Use Vitest .fails() instead of try-catch for apt tests
mishushakov Feb 4, 2026
c0f21a0
fix: Add buildTemplateTestXFail helper for optional tests
mishushakov Feb 4, 2026
4a8f662
fix: Use object destructuring in buildTemplateTestXFail
mishushakov Feb 4, 2026
eca14d6
refactor: Rename buildTemplateTestXFail to buildTemplateTestAllowFail
mishushakov Feb 4, 2026
67a6e74
refactor: Add generic allowFail wrapper for tests
mishushakov Feb 4, 2026
79e5aa1
fix: Use object destructuring in allowFail wrapper
mishushakov Feb 4, 2026
d3f0b67
fix: Use specific buildTemplateTestAllowFail wrapper
mishushakov Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/js-sdk/tests/template/methods/aptInstall.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
import { Template } from '../../../src'
import { buildTemplateTest } from '../../setup'

buildTemplateTest('apt install', async ({ buildTemplate }) => {
// Mark tests as expected to fail (similar to pytest's @pytest.mark.xfail(strict=True))
// Unlike try-catch which silently swallows errors, .fails() properly reports test results:
// - If test fails as expected → test passes (XFAIL behavior)
// - If test unexpectedly passes → test fails, signaling the issue may be fixed

buildTemplateTest.fails('apt install', async ({ buildTemplate }) => {
const template = Template()
.fromImage('ubuntu:24.04')
.skipCache()
Expand All @@ -10,7 +15,7 @@ buildTemplateTest('apt install', async ({ buildTemplate }) => {
await buildTemplate(template)
})

buildTemplateTest(
buildTemplateTest.fails(
Comment thread
cursor[bot] marked this conversation as resolved.
Outdated
'apt install with no install recommends',
async ({ buildTemplate }) => {
const template = Template()
Expand Down
2 changes: 2 additions & 0 deletions packages/python-sdk/tests/async/template_async/methods/test_apt_install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@


@pytest.mark.skip_debug()
@pytest.mark.xfail(reason="aptInstall tests are optional and allowed to fail")
async def test_apt_install(async_build):
template = (
AsyncTemplate().from_image("ubuntu:24.04").skip_cache().apt_install("rolldice")
Expand All @@ -13,6 +14,7 @@ async def test_apt_install(async_build):


@pytest.mark.skip_debug()
@pytest.mark.xfail(reason="aptInstall tests are optional and allowed to fail")
async def test_apt_install_no_install_recommends(async_build):
template = (
AsyncTemplate()
Expand Down
2 changes: 2 additions & 0 deletions packages/python-sdk/tests/sync/template_sync/methods/test_apt_install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@


@pytest.mark.skip_debug()
@pytest.mark.xfail(reason="aptInstall tests are optional and allowed to fail")
def test_apt_install(build):
template = (
Template().from_image("ubuntu:24.04").skip_cache().apt_install("rolldice")
Expand All @@ -13,6 +14,7 @@ def test_apt_install(build):


@pytest.mark.skip_debug()
@pytest.mark.xfail(reason="aptInstall tests are optional and allowed to fail")
def test_apt_install_no_install_recommends(build):
template = (
Template()
Expand Down
Loading