Add support for S3 Multi-Region Access Point (MRAP) URLs (#557)#560
Merged
Add support for S3 Multi-Region Access Point (MRAP) URLs (#557)#560
Conversation
* Add MRAP URL support * test MRAP * update history * use walrus operator * cache bucket parsing * address pr review * fix linter issues * url escape `:` on win and cache * handle Windows drive in test assertion * make lint
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #560 +/- ##
======================================
Coverage 94.0% 94.0%
======================================
Files 28 28
Lines 2203 2222 +19
======================================
+ Hits 2071 2090 +19
Misses 132 132
🚀 New features to boost your workflow:
|
Contributor
|
MRAP does require from #557
The failure looks consistent with that missing dependency. Not sure if we should treat this as optional dep or not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live tests for #557
Add MRAP URL support
test MRAP
update history
use walrus operator
cache bucket parsing
address pr review
fix linter issues
url escape
:on win and cachehandle Windows drive in test assertion
make lint