Skip to content

Add support for S3 Multi-Region Access Point (MRAP) URLs (#557)#560

Merged
pjbull merged 4 commits intomasterfrom
557-live-tests
Apr 29, 2026
Merged

Add support for S3 Multi-Region Access Point (MRAP) URLs (#557)#560
pjbull merged 4 commits intomasterfrom
557-live-tests

Conversation

@pjbull
Copy link
Copy Markdown
Member

@pjbull pjbull commented Apr 29, 2026

Live tests for #557

  • Add MRAP URL support

  • test MRAP

  • update history

  • use walrus operator

  • cache bucket parsing

  • address pr review

  • fix linter issues

  • url escape : on win and cache

  • handle Windows drive in test assertion

  • make lint

* Add MRAP URL support

* test MRAP

* update history

* use walrus operator

* cache bucket parsing

* address pr review

* fix linter issues

* url escape `:` on win and cache

* handle Windows drive in test assertion

* make lint
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

@github-actions github-actions Bot temporarily deployed to pull request April 29, 2026 19:00 Inactive
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.0%. Comparing base (5124aa0) to head (b74ea34).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #560   +/-   ##
======================================
  Coverage    94.0%   94.0%           
======================================
  Files          28      28           
  Lines        2203    2222   +19     
======================================
+ Hits         2071    2090   +19     
  Misses        132     132           
Files with missing lines Coverage Δ
cloudpathlib/s3/s3path.py 100.0% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fedemengo
Copy link
Copy Markdown
Contributor

fedemengo commented Apr 29, 2026

MRAP does require botocore[crt]

from #557

Note: using MRAP paths requires botocore[crt] for SigV4a signing:

pip install botocore[crt]

The failure looks consistent with that missing dependency. Not sure if we should treat this as optional dep or not

@github-actions github-actions Bot temporarily deployed to pull request April 29, 2026 20:57 Inactive
@pjbull pjbull merged commit 1d65750 into master Apr 29, 2026
28 checks passed
@pjbull pjbull deleted the 557-live-tests branch April 29, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants