[6.1] Fixes build issues for AKV Provider#4250
Open
cheenamalhotra wants to merge 10 commits intorelease/6.1from
Open
[6.1] Fixes build issues for AKV Provider#4250cheenamalhotra wants to merge 10 commits intorelease/6.1from
cheenamalhotra wants to merge 10 commits intorelease/6.1from
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates build/signing conditions and OneBranch pipeline templates to address AKV Provider build and publishing flow issues, primarily by keying signing behavior off SigningKeyPath and improving AKV pipeline orchestration.
Changes:
- Switch strong-name signing conditions in SqlClient (netfx/netcore, src/ref) and AKV Provider projects to be driven by
SigningKeyPathpresence rather thanCDP_BUILD_TYPE. - Update OneBranch AKV build templates to support parameterized
ReferenceTypeand to use the repoartifacts/output paths consistently. - Enhance AKV build job to optionally download the just-built MDS NuGet artifact and add it as a local NuGet source before building the AKV Provider.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj | Gate signing and InternalsVisibleTo based on SigningKeyPath instead of CDP_BUILD_TYPE. |
| src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.csproj | Gate reference-assembly signing based on SigningKeyPath. |
| src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj | Gate signing and InternalsVisibleTo based on SigningKeyPath instead of CDP_BUILD_TYPE. |
| src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj | Gate reference-assembly signing based on SigningKeyPath. |
| src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj | Gate AKV Provider signing based on SigningKeyPath. |
| eng/pipelines/onebranch/steps/compound-publish-symbols-step.yml | Adjust symbols folder path to point to repo artifacts/ output location. |
| eng/pipelines/onebranch/steps/compound-extract-akv-apiscan-files-step.yml | Adjust source folder paths for copying AKV DLL/PDB from artifacts/. |
| eng/pipelines/onebranch/steps/compound-build-akv-step.yml | Add referenceType parameter and adjust logging/tree output to artifacts/. |
| eng/pipelines/onebranch/sqlclient-official.yml | Pass softwareFolder/symbolsFolder for apiscan extraction and provide mdsArtifactName to AKV job. |
| eng/pipelines/onebranch/sqlclient-non-official.yml | Pass softwareFolder/symbolsFolder for apiscan extraction and provide mdsArtifactName to AKV job. |
| eng/pipelines/onebranch/jobs/build-akv-official-job.yml | Use artifactDirectory, add optional MDS artifact download + local NuGet source, and wire referenceType as 'Package'. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to successful non-official build: Build 150340