std.datetime.interval: add Interval.fromISOString for ISO 8601 interv… - #11090
Open
burner wants to merge 4 commits into
Open
std.datetime.interval: add Interval.fromISOString for ISO 8601 interv…#11090burner wants to merge 4 commits into
burner wants to merge 4 commits into
Conversation
…al parsing Add Interval.fromISOString to parse ISO 8601 interval strings in both basic and extended formats. Supports: - start/end time points (e.g., '20030115/20030215', '2003-01-15/2003-02-15') - start/duration (e.g., '20030115/P1M', '2003-01-15/P1M') - duration/end (e.g., 'P1M/20030215', 'P1M/2003-02-15') The parser handles both basic (YYYYMMDD) and extended (YYYY-MM-DD) formats, and correctly distinguishes months (in date portion) from minutes (in time portion after 'T'). Duration values accumulate as a Duration via dur!'unit' additions. As with the date and time types in std.datetime, each designator value is validated against the range which its unit can hold (hours at most TimeOfDay.maxHour, minutes/seconds at most 59, months at most 12, days at most 31), so larger spans must use the next larger designator (e.g., PT36H must be written P1DT12H). Changelog: interval_fromisostring
Member
|
I wasn't aware of ISO 8601 intervals, so I'll have to look into them to really comment on the details here. However, if there are both ISO and ISO extended strings, for consistency with the rest of std.datetime, |
Member
Author
fair enough
I can make that change. I expected some pushback on the merging/branching of the two. |
Contributor
|
This does not fully address #10944, and should not close it. There must be a .toISO[Ext]String as well. |
Add Interval.fromISOString and Interval.fromISOExtString to parse ISO 8601 interval strings in the basic and the extended format respectively, like the fromISOString/fromISOExtString pairs of the other std.datetime types. They support: - start/end time points (e.g., '20030115/20030215', '2003-01-15/2003-02-15') - start/duration (e.g., '20030115/P1M', '2003-01-15/P1M') - duration/end (e.g., 'P1M/20030215', 'P1M/2003-02-15') Both share a private parseISOInterval helper which splits the string on the slash and delegates each time point to TP.fromISOString or TP.fromISOExtString, so no format detection is needed. Duration values accumulate as a Duration via dur!'unit' additions. As with the date and time types in std.datetime, each designator value is validated against the range which its unit can hold (hours at most TimeOfDay.maxHour, minutes/seconds at most 59, months at most 12, days at most 31), so larger spans must use the next larger designator (e.g., PT36H must be written P1DT12H). Changelog: interval_fromisostring
…rval types Add Interval.toISOString and Interval.toISOExtString, which emit the begin and end time points in the basic and the extended ISO 8601 format separated by a slash. They round trip with fromISOString/fromISOExtString. Per ISO 8601, an omitted time point means that it is unknown, so PosInfInterval and NegInfInterval convert to '20030115/' and '/20030215' respectively, and the corresponding fromISOString/fromISOExtString parse those strings back. Changelog: interval_fromisostring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…al parsing
Add Interval.fromISOString to parse ISO 8601 interval strings in both basic and extended formats. Supports:
The parser handles both basic (YYYYMMDD) and extended (YYYY-MM-DD) formats, and correctly distinguishes months (in date portion) from minutes (in time portion after 'T'). Duration values accumulate as a Duration via dur!'unit' additions. As with the date and time types in std.datetime, each designator value is validated against the range which its unit can hold (hours at most TimeOfDay.maxHour, minutes/seconds at most 59, months at most 12, days at most 31), so larger spans must use the next larger designator (e.g., PT36H must be written P1DT12H).
Changelog: interval_fromisostring
Rationale
Feature request or issue tracking
Closes #10944
Pre-review checklist
LLM/AI disclosure
This PR was written mostly by an LLM/AI. But I had to change more things than I hoped for.