Add isCharacter to phobos.sys.traits. - #11089
Merged
Merged
Conversation
isCharacter is the Phobos v3 equivalent to std.traits' isSomeChar. However, unlike isSomeChar, isCharacter does not accept enum types with a base type which is a character type (since that's one of the mistakes in Phobos v2 that we're trying to fix). The type must be either char, wchar, or dchar (ignoring qualifiers).
thewilsonator
approved these changes
Sep 3, 2026
Member
Author
|
Lovely, we have an unrelated buildkite failure. |
LightBender
approved these changes
Sep 3, 2026
Contributor
|
Everyone is getting it. |
Contributor
|
@jmdavis We know what it is, Nic or I can (and will) override. |
Member
Author
Since it's pretty clearly unrelated, I figured. Any idea what's causing the failures? EDIT: And Adam replied while I was posting my reply... LOL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isCharacter is the Phobos v3 equivalent to std.traits' isSomeChar. However, unlike isSomeChar, isCharacter does not accept enum types with a base type which is a character type (since that's one of the mistakes in Phobos v2 that we're trying to fix). The type must be either char, wchar, or dchar (ignoring qualifiers).