Fix #23745 - inline: scan local symbols in a deterministic order - #23746
Open
bmwiedemann wants to merge 1 commit into
Open
Fix #23745 - inline: scan local symbols in a deterministic order#23746bmwiedemann wants to merge 1 commit into
bmwiedemann wants to merge 1 commit into
Conversation
The symbol table iterates in bucket order, which follows the addresses of the Identifier keys and so varies between runs with ASLR. The order matters because inlining one nested function changes the inline cost of the others, so different runs inlined different functions, making builds unreproducible: compiling dmd's own ob.d gave a different .o almost every run. Sort the symbols by name before visiting them, as dtoh.d already does for module members. The dshell test compiles an order-sensitive module ten times and requires bit-identical objects; without the fix each run gives a different object file. Fixes dlang#23745
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The symbol table iterates in bucket order, which follows the addresses of the Identifier keys and so varies between runs with ASLR. The order matters because inlining one nested function changes the inline cost of the others, so different runs inlined different functions, making builds unreproducible: compiling dmd's own
ob.dgave a different .o almost every run.Sort the symbols by name before visiting them, as
dtoh.dalready does for module members.Fixes #23745