osthread: divides OS-related code over *_impl modules - #23734
Merged
Conversation
denizzzka
force-pushed
the
osthread_split9
branch
from
August 29, 2026 12:00
08e3610 to
00768fa
Compare
DMD perf checkNo differences above the noise thresholds. All measurements
10bf5e4 vs merge-base b41cb91 · about these metrics |
denizzzka
force-pushed
the
osthread_split9
branch
2 times, most recently
from
August 29, 2026 14:10
3d69db6 to
880c5f4
Compare
denizzzka
force-pushed
the
osthread_split9
branch
from
August 29, 2026 19:26
81739a1 to
5e98880
Compare
denizzzka
commented
Aug 29, 2026
denizzzka
force-pushed
the
osthread_split9
branch
2 times, most recently
from
August 30, 2026 19:56
4087c6b to
54fb03b
Compare
denizzzka
force-pushed
the
osthread_split9
branch
from
August 30, 2026 20:06
54fb03b to
0c897b3
Compare
denizzzka
marked this pull request as ready for review
August 31, 2026 06:46
denizzzka
force-pushed
the
osthread_split9
branch
from
August 31, 2026 06:46
0c897b3 to
10bf5e4
Compare
Contributor
Author
|
Ready to review |
thewilsonator
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is happening is a part of the process of separating code from different platforms into different modules. This is latest PR on this.
I decided to leave
callWithStackShell()as it is (without pulling it apart into *_impl modules) because it’s already good displays OS + ABI features and pulling it apart will worsen its readability. If it gets in the way in the future we'll do something about it.All other
version()branches related to different OSes were abolished.Previous PRs:
#23150
#23361
#23439
#23447
#23460
#23476
#23481
#23487
#23488
#23516
#23749