Fix #23731 - undefined __xopEquals/__xtoHash for instantiated struct - #23732
Draft
dkorpel wants to merge 1 commit into
Draft
Fix #23731 - undefined __xopEquals/__xtoHash for instantiated struct#23732dkorpel wants to merge 1 commit into
dkorpel wants to merge 1 commit into
Conversation
dkorpel
marked this pull request as draft
August 28, 2026 11:31
…ruct 786dc71 stopped emitting the special TypeInfo members alongside the TypeInfo of a template-instantiated struct whose own codegen was elided, assuming they are always emitted with the StructDeclaration elsewhere. That does not hold when `ti.minst` is null (a speculative instance whose TypeInfo was requested anyway) or a non-root module that is not part of the compilation: nothing emits `TemplateInstance.toObjFile()`, so the TypeInfo emitted here is left referencing symbols no object file defines. Restore emitting them next to the TypeInfo, as before 2.113. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
Is this good to go? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23731