Fix issue 19718 - check function safety attributes during template deduction - #23707
Open
usefahmed07 wants to merge 4 commits into
Open
Fix issue 19718 - check function safety attributes during template deduction#23707usefahmed07 wants to merge 4 commits into
usefahmed07 wants to merge 4 commits into
Conversation
…duction When deducing a template parameter T from a function-literal argument against a declared parameter type like `T function(ref S) @safe` or `T delegate(ref S) @safe`, deduceType's TypeFunction visitor only checked varargs, linkage, and per-parameter covariance. It never checked that the argument's own function attributes (in particular @safe/@System) satisfy what the parameter type requires. As a result, an @System function literal could be wrongly deduced as an exact match against an @safe parameter type, and when this happened for two overloads simultaneously (function pointer vs delegate), the compiler reported a confusing 'matches multiple overloads' ambiguity error instead of the real 'no overload is callable' safety error. This adds a trust (safety) compatibility check right after the existing varargs/linkage check, mirroring the same trust-covariance rule already used elsewhere in the compiler (Type.covariant). dlang#19718
Contributor
Contributor
|
This is a breaking change, and there's more attributes than |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19718