Skip to content

Add Specializations - #292

Closed
jason-fox wants to merge 13 commits into
dita-bootstrap:developfrom
jason-fox:feature/specialize
Closed

jason-fox wants to merge 13 commits into
dita-bootstrap:developfrom
jason-fox:feature/specialize

Conversation

@jason-fox

Copy link
Copy Markdown
Collaborator
  • Add DTD descriptors
  • Amend XSL
  • Update documentation

Currently "old style" sample and "new style" sample-ext are both available, but this could be amended.

@jason-fox
jason-fox requested a review from infotexture April 3, 2026 16:22
@infotexture

Copy link
Copy Markdown
Collaborator

Currently "old style" sample and "new style" sample-ext are both available, but this could be amended.

I see the new source files here, but it looks like the new sample-ext versions aren't included in the default .github/dita-ot/html.xml build, so I had to build the docs from sample-ext to see those results.

Apart from updating the code samples to show the specializations instead of the output classes, I think we'd need to explain that there are 2 ways of doing things with this new approach (at least if we plan to include both in a single plug-in).

Per discussion in https://github.com/infotexture/dita-bootstrap/issues/289#issuecomment-4230164369, we might want to consider separating the specializations and shipping them as a separate plug-in, so people can decide which approach they prefer, and keep the docs focused on one approach or another.

The docs for the original version could of course link to the specialized plug-in (and vice-versa), so everyone is aware that both exist.

@jason-fox
jason-fox marked this pull request as draft April 11, 2026 22:40
@jason-fox jason-fox closed this Apr 12, 2026
@jason-fox
jason-fox deleted the feature/specialize branch April 15, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants