Skip to content

chore(sns_aggregator): rebaseline candid bindings to didc 0.5.4 - #7889

Open
yhabib wants to merge 2 commits into
mainfrom
chore-rebaseline-sns-aggregator-patches
Open

chore(sns_aggregator): rebaseline candid bindings to didc 0.5.4#7889
yhabib wants to merge 2 commits into
mainfrom
chore-rebaseline-sns-aggregator-patches

Conversation

@yhabib

@yhabib yhabib commented May 26, 2026

Copy link
Copy Markdown
Contributor

Motivation

The daily aggregator-update workflow has been failing since the didc 0.4.0 → 0.5.4 bump in #7812. The committed bindings were never regenerated under the new didc, so the codegen output drifted from the checked-in files and ic_sns_ledger.patch no longer applied cleanly.

Changes

  • Regenerated all five ic_sns_*.rs candid bindings under didc 0.5.4.
  • Re-derived ic_sns_ledger.patch against the new baseline (same 3 derive-stripping hunks, updated context).
  • Updated the list_topics call in upstream.rs to pass &ListTopicsRequest to match the new by-reference canister-method signatures.

@yhabib
yhabib requested a review from a team as a code owner May 26, 2026 08:44
The daily aggregator-update workflow has been failing since the didc
0.4.0 → 0.5.4 bump in #7812. The committed bindings were never
regenerated under the new didc, so the codegen output drifted from the
checked-in files and `ic_sns_ledger.patch` no longer applied cleanly.

- Regenerated all five `ic_sns_*.rs` candid bindings under `didc 0.5.4`.
- Re-derived `ic_sns_ledger.patch` against the new baseline (same 3 derive-stripping hunks, updated context).
- Updated the `list_topics` call in `upstream.rs` to pass `&ListTopicsRequest` to match the new by-reference canister-method signatures.
didc 0.5.4 emits doc comments propagated from the upstream .did files
that trip the pedantic clippy::doc_markdown lint (missing backticks
around identifiers, bare URLs). These comments come back on every
regeneration, so allow the pedantic lint group in did2rs.header
instead of trying to fix the doc comments themselves.
@yhabib
yhabib force-pushed the chore-rebaseline-sns-aggregator-patches branch from b4e1795 to 75b53a0 Compare September 1, 2026 12:27
@zeropath-ai

zeropath-ai Bot commented Sep 1, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to 75b53a0.

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► rs/sns_aggregator/src/types/ic_sns_governance.rs
    Add pedantic clippy allowance and several field/document additions/renames
► rs/sns_aggregator/src/types/ic_sns_ledger.rs
    Introduce numerous doc comments, rename types (ICRC3Value to ICRC3Value), adjust type aliases (GetBlocksResult, GetTransactionsResponse, etc.), add new fields and documentation for blocks/transactions/archives, adjust method signatures to take references, and rename several methods (icrc_103_get_allowances to icrc103_get_allowances, icrc_106_get_index_principal to icrc106_get_index_principal, etc.)
► rs/sns_aggregator/src/types/ic_sns_root.rs
    Add pedantic clippy allowance, introduce CleanUpFailedRegisterExtensionResultOk and related type changes, adjust several method signatures to take references and rename result types, and add documentation comments
► rs/sns_aggregator/src/types/ic_sns_swap.rs
    File header updated (no functional change shown in snippet)
Refactor ► rs/sns_aggregator/src/types/ic_sns_root.rs
    Refactor of several Result types to standard Rust Result, and update service method signatures to accept &self arguments where applicable
► rs/sns_aggregator/src/types/ic_sns_ledger.rs
    Refactor of various response types to standard Result and added extensive documentation/comments
Other ► rs/sns_aggregator/src/types/ic_sns_governance.rs
    Add #![allow(clippy::pedantic)] and minor doc/comment updates
► rs/sns_aggregator/src/types/ic_sns_ledger.patch and ic_sns_ledger.rs
    Patch-style context changes reflecting broader schema evolution (doc comments, type aliases, and field documentation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant