Skip to content

fix: encode RFC 3339 UTC offset as "Z" instead of "+0000" #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ElonPark merged 4 commits into from
Jul 15, 2026
Merged

fix: encode RFC 3339 UTC offset as "Z" instead of "+0000" #27

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
528f639
fix: encode RFC 3339 UTC offset as "Z" instead of "+0000"
ElonPark Jul 13, 2026
e2c10d0
test: cover RFC 3339 decode of legacy +0000 / +00:00 / Z offsets
ElonPark Jul 13, 2026
5727b7f
test: migrate RFC3339StrategyTests to Swift Testing
ElonPark Jul 13, 2026
18808b4
test: expand RFC3339Strategy coverage as BDD suites
ElonPark Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/KarrotCodableKit/BetterCodable/DateValue/Strategy/RFC3339Strategy.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public struct RFC3339Strategy: DateValueCodableStrategy {
let dateFormatter = DateFormatter()
dateFormatter.timeZone = TimeZone(secondsFromGMT: 0)
dateFormatter.locale = Locale(identifier: "en_US_POSIX")
dateFormatter.dateFormat = "yyyy-MM-dd'T'HH:mm:ssZ"
dateFormatter.dateFormat = "yyyy-MM-dd'T'HH:mm:ssZZZZZ"
Comment thread
coderabbitai[bot] marked this conversation as resolved.
return dateFormatter
}()

Expand Down
24 changes: 24 additions & 0 deletions Tests/KarrotCodableKitTests/BetterCodable/DateValue/RFC3339StrategyEncodingTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
//
// RFC3339StrategyEncodingTests.swift
// KarrotCodableKit
//
// Created by Elon on 7/13/26.
//

import XCTest

import KarrotCodableKit

final class RFC3339StrategyEncodingTests: XCTestCase {
func testEncodingUTCDateUsesStandardCompliantOffset() throws {
// given
let date = Date(timeIntervalSince1970: 1715082540) // 2024-05-07T11:49:00 UTC

// when
let result = RFC3339Strategy.encode(date)

// then
// RFC 3339 requires the UTC offset to be "Z" (or "+00:00"), not the colon-less "+0000".
XCTAssertEqual(result, "2024-05-07T11:49:00Z")
}
}
Loading