Skip to content

[-] apply non-recursive yaml dir reading, fixes #1368#1382

Open
pashagolub wants to merge 2 commits intomasterfrom
1368-fix-YAML-folder-load
Open

[-] apply non-recursive yaml dir reading, fixes #1368#1382
pashagolub wants to merge 2 commits intomasterfrom
1368-fix-YAML-folder-load

Conversation

@pashagolub
Copy link
Copy Markdown
Collaborator

replace WalkDir with filepath.Glob, those functions never intended to be recursive in the first place

replace `WalkDir` with `filepath.Glob`, those functions never intended
to be recursive in the first place
@pashagolub pashagolub self-assigned this Apr 29, 2026
@pashagolub pashagolub added the bug Something isn't working label Apr 29, 2026
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 25111967276

Coverage decreased (-0.09%) to 83.202%

Details

  • Coverage decreased (-0.09%) from the base build.
  • Patch coverage: 6 uncovered changes across 2 files (11 of 17 lines covered, 64.71%).
  • 10 coverage regressions across 2 files.

Uncovered Changes

File Changed Covered %
internal/metrics/yaml.go 9 6 66.67%
internal/sources/yaml.go 8 5 62.5%

Coverage Regressions

10 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
internal/metrics/yaml.go 9 82.76%
internal/sources/yaml.go 1 89.83%

Coverage Stats

Coverage Status
Relevant Lines: 5316
Covered Lines: 4423
Line Coverage: 83.2%
Coverage Strength: 0.95 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Directory-based YAML source loading reads hidden Kubernetes mount internals and causes duplicate sources

2 participants