2D Julia Operators#331
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@bewagner1 The curl operator seems wrong, and will be a point of contention for many. I suggest removing it (also it doesn't have a test) to speed up the approval. |
|
Yea I was wondering how it is mimetic operator. Doesn't seem to fit in with the rest |
|
Hi @bewagner1 , thank you so much for your contribution! Now that we have a few more examples, I would like them to be organized in a directory structure that reflects the same organization and categories we have chosen for our documentation. See the |
Signed-off-by: Ben Wagner <121269611+bewagner1@users.noreply.github.com>
|
I think that the docs in theory are good but for a reason I cannot figure out, whenever I click through the links for the examples, I encounter pages that are not |
What type of PR is this? (check all applicable)
Description
Implementation of the 2-D operators
div,grad,curl, andlapin julia as well as their periodic, mixed periodicity, and non uniform variants.Related Issues & Documents
QA Instructions, Screenshots, Recordings
Compare relevant code and examples to MATLAB implementaiton
Added/updated tests?
have not been included
Nullity tests for all operators
Read Contributing Guide and Code of Conduct
[optional] Are there any post deployment tasks we need to perform?
None that I can think of
[optional] What gif best describes this PR or how it makes you feel?