Skip to content

2D Julia Operators#331

Open
bewagner1 wants to merge 28 commits intocsrc-sdsu:mainfrom
bewagner1:bpw/jl2D
Open

2D Julia Operators#331
bewagner1 wants to merge 28 commits intocsrc-sdsu:mainfrom
bewagner1:bpw/jl2D

Conversation

@bewagner1
Copy link
Copy Markdown
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Example
  • Documentation

Description

Implementation of the 2-D operators div, grad, curl, and lap in julia as well as their periodic, mixed periodicity, and non uniform variants.

Related Issues & Documents

QA Instructions, Screenshots, Recordings

Compare relevant code and examples to MATLAB implementaiton

Added/updated tests?

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Nullity tests for all operators

Read Contributing Guide and Code of Conduct

[optional] Are there any post deployment tasks we need to perform?

None that I can think of

[optional] What gif best describes this PR or how it makes you feel?

@bewagner1

This comment was marked as outdated.

@bewagner1 bewagner1 marked this pull request as ready for review April 16, 2026 05:01
@bewagner1

This comment was marked as outdated.

Comment thread julia/MOLE.jl/src/BCs/scalarBC.jl Outdated
Comment thread julia/MOLE.jl/src/BCs/scalarBC.jl Outdated
@jbrzensk
Copy link
Copy Markdown
Collaborator

@bewagner1 The curl operator seems wrong, and will be a point of contention for many. I suggest removing it (also it doesn't have a test) to speed up the approval.

@bewagner1
Copy link
Copy Markdown
Collaborator Author

Yea I was wondering how it is mimetic operator. Doesn't seem to fit in with the rest

Comment thread julia/MOLE.jl/examples/elliptic2DXDirichletYDirichlet.jl Outdated
Comment thread julia/MOLE.jl/examples/elliptic2DXPerYDirichlet.jl Outdated
Comment thread julia/MOLE.jl/examples/parabolic/parabolic2D.jl
@valeriabarra
Copy link
Copy Markdown
Collaborator

Hi @bewagner1 , thank you so much for your contribution!

Now that we have a few more examples, I would like them to be organized in a directory structure that reflects the same organization and categories we have chosen for our documentation. See the examples/ directory in our docs. Please update the structure of the mole/julia/MOLE.jl/examples/ directory accordingly.
Please, also use the same directory structure in the mole/julia/MOLE.jl/docs/src/ directory (where we currently do not have an examples/ subdirectory - you would need to create one)

Comment thread julia/MOLE.jl/examples/elliptic/elliptic1D.jl Outdated
Comment thread julia/MOLE.jl/docs/src/index.md
Comment thread julia/MOLE.jl/examples/parabolic/parabolic2D.jl Outdated
bewagner1 and others added 3 commits May 4, 2026 21:52
Signed-off-by: Ben Wagner <121269611+bewagner1@users.noreply.github.com>
@bewagner1
Copy link
Copy Markdown
Collaborator Author

I think that the docs in theory are good but for a reason I cannot figure out, whenever I click through the links for the examples, I encounter pages that are not .html files, so you have to click on index.html to actually render the page. Any advice would be appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2D operators for MOLE.jl

3 participants