fix: restore tab icons and make tsc pass - #1160
Merged
Merged
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
ziracmo
approved these changes
Sep 16, 2026
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The persona tab lookup cannot find the hidden tab because the rendered element lacks data-value.
Pull request overview
Restores the active Docusaurus Tabs swizzle, fixes TypeScript issues, and adds CI type checking.
Changes:
- Corrects the Tabs directory casing and component typing.
- Updates TypeScript configuration and tab components.
- Adds a
typecheckscript and CI workflow step.
File summaries
| File | Summary |
|---|---|
crowdsec-docs/tsconfig.json |
Extends Docusaurus TypeScript configuration. |
crowdsec-docs/src/theme/Tabs/index.tsx |
Restores custom tabs and icons; persona tab lookup remains unsynchronized. |
crowdsec-docs/src/components/premium-upgrade/tabs-with-persona.tsx |
Updates TabItem typing. |
crowdsec-docs/src/components/formatted-tabs.tsx |
Reuses tab value definitions. |
crowdsec-docs/package.json |
Adds the typecheck script. |
.github/workflows/lint.yaml |
Runs type checking in CI. |
Review details
Suppressed comments (1)
crowdsec-docs/src/theme/Tabs/index.tsx:61
TabsWithPersonalooks up the hidden tab with[role="tab"][data-value="${value}"], but this tab element never renders adata-valueattribute. With this swizzled component active, the lookup returnsnull, sogroupIdstate is not synchronized or persisted when a persona is selected; add the attribute here or change the selector.
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
src/theme/tabs→Tabsso the swizzled Tabs (with OS icons) is active again; it was silently disabled by the case change in 18f37ee.Extend
@docusaurus/tsconfig(automatic JSX runtime, skipLibCheck): 214 → 0tscerrors after fixing 2 components.Add
npm run typecheckto the Code quality workflow.