Skip to content

Fix libde265 on arm64 macOS asm build bug #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crazywhalecc merged 2 commits into from
Apr 22, 2026
Merged

Fix libde265 on arm64 macOS asm build bug #1117

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14fc3f8
Fix libde265 on arm64 macOS asm build bug
crazywhalecc Apr 20, 2026
4e9edf6
Update src/SPC/builder/unix/library/libde265.php
crazywhalecc Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/SPC/ConsoleApplication.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
*/
final class ConsoleApplication extends Application
{
public const string VERSION = '2.8.5';
public const string VERSION = '2.8.6';

public function __construct()
{
Expand Down
3 changes: 2 additions & 1 deletion src/SPC/builder/unix/library/libde265.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ protected function build(): void
UnixCMakeExecutor::create($this)
->addConfigureArgs(
'-DENABLE_SDL=OFF',
'-DENABLE_DECODER=OFF'
'-DENABLE_DECODER=OFF',
'-DHAVE_ARM=OFF',
Copy link
Copy Markdown
Collaborator

@henderkes henderkes Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps do this on mac only? neon are generally helpful in my builds on rhel 9 & 10

Copy link
Copy Markdown
Owner Author

@crazywhalecc crazywhalecc Apr 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux aarch64 may also have this bug though.

However, considering this chain: libde265-libheif-imagemagick-imagick, the only function of libde265 assembly should be HEVC/HEIF things. I'm not sure if adding this assembly is worthwhile for the benefit of this extension. In any case, arm64 assembly is likely missing, it only has armv7 assembly. x86 assembly is compatible with x64, which may explain why it has consistently compiled successfully.

Copy link
Copy Markdown
Owner Author

@crazywhalecc crazywhalecc Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, libde265 have HAVE_NEON option, this looks more accurate, and we don't worry about x86, it just because it depends on HAVE_ARM which is negative on x86. Let me change to HAVE_NEON=OFF.

Suggested change
'-DHAVE_ARM=OFF',
'-DHAVE_NEON=OFF',

Copy link
Copy Markdown
Collaborator

@henderkes henderkes Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpociot does this still fix your issue?

Copy link
Copy Markdown
Contributor

@mpociot mpociot Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, still fails for me with HAVE_NEON=OFF

Copy link
Copy Markdown
Owner Author

@crazywhalecc crazywhalecc Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, still fails for me with HAVE_NEON=OFF

With clean downloads and without pre-built content? (cannot contain --prefer-pre-built option)

Copy link
Copy Markdown
Contributor

@mpociot mpociot Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, looks like it wasn't the proper build 🤦
Yes, I can confirm - this fix works too 👍

)
->build();
$this->patchPkgconfPrefix(['libde265.pc']);
Expand Down
10 changes: 5 additions & 5 deletions src/globals/test-extensions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
// 'macos-15-intel', // bin/spc for x86_64
'macos-15', // bin/spc for arm64
// 'ubuntu-latest', // bin/spc-alpine-docker for x86_64
'ubuntu-22.04', // bin/spc-gnu-docker for x86_64
// 'ubuntu-22.04', // bin/spc-gnu-docker for x86_64
// 'ubuntu-24.04', // bin/spc for x86_64
'ubuntu-22.04-arm', // bin/spc-gnu-docker for arm64
// 'ubuntu-22.04-arm', // bin/spc-gnu-docker for arm64
// 'ubuntu-24.04-arm', // bin/spc for arm64
// 'windows-2022', // .\bin\spc.ps1
// 'windows-2025',
Expand All @@ -50,13 +50,13 @@

// If you want to test your added extensions and libs, add below (comma separated, example `bcmath,openssl`).
$extensions = match (PHP_OS_FAMILY) {
'Linux', 'Darwin' => 'openssl,brotli',
'Linux', 'Darwin' => 'gd,imagick',
'Windows' => 'bcmath,brotli,bz2,ctype,curl,dom,exif,fileinfo,filter,ftp,gd,iconv,intl,mbregex,mbstring,mysqli,mysqlnd,opcache,openssl,pdo,pdo_mysql,pdo_pgsql,pgsql,session,simdjson,simplexml,sodium,sqlite3,tokenizer,xml,xmlreader,xmlwriter,zip,zlib',
};

// If you want to test shared extensions, add them below (comma separated, example `bcmath,openssl`).
$shared_extensions = match (PHP_OS_FAMILY) {
'Linux' => 'zstd',
'Linux' => '',
'Darwin' => '',
'Windows' => '',
};
Expand All @@ -66,7 +66,7 @@

// If you want to test extra libs for extensions, add them below (comma separated, example `libwebp,libavif`). Unnecessary, when $with_suggested_libs is true.
$with_libs = match (PHP_OS_FAMILY) {
'Linux', 'Darwin' => 'krb5',
'Linux', 'Darwin' => 'libde265',
'Windows' => '',
};

Expand Down
Loading