Skip to content

Fix old PHP extension with newer C standard bug #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crazywhalecc wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix old PHP extension with newer C standard bug #1089

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1272acd
Fix bcmath with c23 bug
crazywhalecc Apr 10, 2026
0ed1bbc
Fix typo
crazywhalecc Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/SPC/store/SourcePatcher.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,15 @@ public static function patchBeforeConfigure(BuilderBase $builder): void
FileSystem::replaceFileRegex(SOURCE_PATH . '/php-src/configure', '/have_capstone="yes"/', 'have_capstone="no"');
}

// PHP 8.2 and below: bcmath libbcmath uses K&R style C function
if (is_unix() && $builder->getPHPVersionID() < 80300) {
FileSystem::replaceFileStr(
SOURCE_PATH . '/php-src/configure',
"for ac_arg in '' -std=gnu23",
"for ac_arg in ''"
);
Comment on lines +130 to +134
Copy link
Copy Markdown
Collaborator

@henderkes henderkes Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should explicitly give gnu17 instead, same as in the other one because GCC 15 and Clang 21 default to c23 even if it isn't explicitly passed.

}

if (file_exists(SOURCE_PATH . '/php-src/configure.ac.bak')) {
// restore configure.ac
FileSystem::restoreBackupFile(SOURCE_PATH . '/php-src/configure.ac');
Expand Down