Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where the elevated session modal was always shown when setting up 2SV, even if the user already had an elevated session.
This was also leading to a weird behaviour: dismissing that elevated session modal without providing valid credentials would show the 2SV setup slideout. The problem was that the modal shouldn’t have shown in the first place, since the session was already genuinely elevated. (If the session isn’t elevated and the modal shows, if you input wrong credentials and then dismiss the modal, you won’t see the setup slideout.)
Related issues
n/a; found and reported by @timkelty