Skip to content

Update Emscripten build to llvm 22#907

Open
mcbarton wants to merge 22 commits intocompiler-research:mainfrom
mcbarton:emscripten-llvm22
Open

Update Emscripten build to llvm 22#907
mcbarton wants to merge 22 commits intocompiler-research:mainfrom
mcbarton:emscripten-llvm22

Conversation

@mcbarton
Copy link
Copy Markdown
Collaborator

@mcbarton mcbarton commented Apr 22, 2026

No description provided.

@mcbarton mcbarton marked this pull request as draft April 22, 2026 08:47
@mcbarton mcbarton mentioned this pull request Apr 22, 2026
Open
7 tasks
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.87%. Comparing base (cbef716) to head (c1714df).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #907   +/-   ##
=======================================
  Coverage   80.87%   80.87%           
=======================================
  Files          15       15           
  Lines        4707     4707           
=======================================
  Hits         3807     3807           
  Misses        900      900
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcbarton mcbarton force-pushed the emscripten-llvm22 branch 3 times, most recently from 3887f62 to 5e14c06 Compare April 22, 2026 10:12
@mcbarton mcbarton force-pushed the emscripten-llvm22 branch from f2ae833 to ddbb2ac Compare April 22, 2026 11:21
@mcbarton
Copy link
Copy Markdown
Collaborator Author

mcbarton commented Apr 22, 2026

The current failures for the Emscripten llvm 22 based build

1: [  FAILED  ] CppInterOpTest/InProcessJIT.FunctionReflection_JitCallAdvanced, where TypeParam = <type>
1: [  FAILED  ] CppInterOpTest/InProcessJIT.FunctionReflection_ConstructPOD, where TypeParam = <type>
3: [  FAILED  ] TracingTest.JitCallWrapperSourceLogged

@mcbarton
Copy link
Copy Markdown
Collaborator Author

mcbarton commented Apr 22, 2026

@anutosh491 do you see anything obvious from the failures, as to what might have regressed on the llvm side to make these tests fail? Looking at least 2 of the tests, they failed for older llvms, so I assume you did some fix in the past to make them work, and that might have regressed.

anutosh491
anutosh491 reviewed Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@anutosh491 anutosh491 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember sadly if something was done to get the above tests working :(

But that being said I think I know how to fix the patches upstream. I have something I mind I need to find the time to try out.

I'll try something this weekend !

@mcbarton mcbarton marked this pull request as ready for review April 25, 2026 10:23
@mcbarton mcbarton changed the title [wip] Update Emscripten build to llvm 22 Update Emscripten build to llvm 22 Apr 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 25, 2026

clang-tidy review says "All clean, LGTM! 👍"

github-actions[bot]
github-actions Bot reviewed Apr 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread unittests/CppInterOp/FunctionReflectionTest.cpp
Comment thread unittests/CppInterOp/FunctionReflectionTest.cpp
Comment thread unittests/CppInterOp/TracingTests.cpp Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 25, 2026

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 25, 2026

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 25, 2026

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 25, 2026

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 25, 2026

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 25, 2026

clang-tidy review says "All clean, LGTM! 👍"

github-actions[bot]
github-actions Bot reviewed Apr 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread unittests/CppInterOp/TracingTests.cpp
@mcbarton mcbarton requested a review from anutosh491 April 26, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@anutosh491 anutosh491 Awaiting requested review from anutosh491

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mcbarton @anutosh491