fix: avoid NameError in time-frame error message (file_path -> file_name) - #613
Open
Anai-Guo wants to merge 1 commit into
Open
fix: avoid NameError in time-frame error message (file_path -> file_name)#613Anai-Guo wants to merge 1 commit into
Anai-Guo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
investing_algorithm_framework/app/reporting/generate.py,get_time_frame_from_file_name(file_name)builds a helpful error message that references an undefined namefile_path:The function parameter is
file_name;file_pathis not defined in this scope (nor imported anywhere), so theexcept ValueErrorhandler itself raisesNameError: name 'file_path' is not definedinstead of the intended, informativeValueError.Impact
TimeFrame.from_string()raisesValueError("Could not convert ... to TimeFrame")for any unrecognized time-frame token (investing_algorithm_framework/domain/models/time_frame.py).get_time_frame_from_file_nameis called in a loop over data files inadd_ohlcv_data_completeness_charts(generate.py:129). So whenever an OHLCV CSV's file name contains an unrecognized time-frame segment, the report generation crashes with a confusingNameErrorin the error path, masking the real diagnostic the code was trying to surface.Fix
Reference the actual parameter name,
file_name:One-word change, no behavior change beyond the error message now rendering correctly.
🤖 Generated with Claude Code