Skip to content

chore: Bump structarmed to ^0.17 and enable CodeQuality preset - #10520

Merged
samsonasik merged 2 commits into
codeigniter4:developfrom
samsonasik:chore-structarmed-017
Sep 4, 2026
Merged

chore: Bump structarmed to ^0.17 and enable CodeQuality preset#10520
samsonasik merged 2 commits into
codeigniter4:developfrom
samsonasik:chore-structarmed-017

Conversation

@samsonasik

@samsonasik samsonasik commented Sep 4, 2026

Copy link
Copy Markdown
Member

Description

This PR bump structarmed to ^0.17 and enable CodeQuality preset. The CodeQuality preset applied rules:

  • MustBeStaticAnonymousFunctionRule: add static to closure/arrow function when possible
  • LargeNumericLiteralMustUseSeparatorRule: use separator _ on large numeric.

they are FixableInterface instance rules and applied with:

vendor/bin/structarmed analyze --fix

If you need separate PR, just let me know :)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
samsonasik marked this pull request as draft September 4, 2026 02:53
@samsonasik
samsonasik marked this pull request as ready for review September 4, 2026 02:55
@samsonasik

Copy link
Copy Markdown
Member Author

Ready to review/merge 👍

@samsonasik

Copy link
Copy Markdown
Member Author

Thank you @paulbalandan for the review, let's merge ;)

@samsonasik
samsonasik merged commit c32a6e5 into codeigniter4:develop Sep 4, 2026
56 checks passed
@samsonasik
samsonasik deleted the chore-structarmed-017 branch September 4, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants