test: apply code review suggestions for Session FileHandler tests

Author: gr8man

tests/_support/Session/FaultyStream.php

@@ -24,11 +24,19 @@
  */
 final class FaultyStream
 {
-    public $context;
+    /**
+     * @var resource|null
+     */
+    public mixed $context = null;
+
     private static bool $failLock  = false;
     private static bool $failRead  = false;
     private static bool $failWrite = false;
-    private $stream;
+
+    /**
+     * @var resource|false|null
+     */
+    private mixed $stream = null;
 
     public static function failLock(bool $fail): void
     {
@@ -66,7 +74,15 @@ public function stream_read(int $count): false|string
 
     public function stream_write(string $data): false|int
     {
-        return self::$failWrite ? false : fwrite($this->stream, $data);
+        if (self::$failWrite) {
+            $stream = fopen('php://temp', 'r');
+            $result = fwrite($stream, $data);
+            fclose($stream);
+
+            return $result;
+        }
+
+        return fwrite($this->stream, $data);
     }
 
     public function stream_lock(): bool
@@ -108,11 +124,26 @@ public function stream_stat(): array
      * Reports a regular file so that `is_file()` and `filesize()` behave like
      * they do for a real session file.
      *
-     * @return array<string, int>
+     * @return array<int|string, int>
      */
     public function url_stat(): array
     {
+        $now = time();
+
         return [
+            0         => 0,
+            1         => 0,
+            2         => 0o100600,
+            3         => 1,
+            4         => 0,
+            5         => 0,
+            6         => 0,
+            7         => 5,
+            8         => $now,
+            9         => $now,
+            10        => $now,
+            11        => -1,
+            12        => -1,
             'dev'     => 0,
             'ino'     => 0,
             'mode'    => 0o100600,
@@ -121,9 +152,9 @@ public function url_stat(): array
             'gid'     => 0,
             'rdev'    => 0,
             'size'    => 5,
-            'atime'   => time(),
-            'mtime'   => time(),
-            'ctime'   => time(),
+            'atime'   => $now,
+            'mtime'   => $now,
+            'ctime'   => $now,
             'blksize' => -1,
             'blocks'  => -1,
         ];

tests/system/Session/Handlers/FileHandlerTest.php

@@ -20,6 +20,7 @@
 use Config\Logger as LoggerConfig;
 use Config\Session as SessionConfig;
 use PHPUnit\Framework\Attributes\Group;
+use PHPUnit\Framework\Attributes\RequiresOperatingSystem;
 use Tests\Support\Session\FaultyStream;
 use Tests\Support\Session\FileHandlerCloseFail;
 
@@ -36,13 +37,15 @@ final class FileHandlerTest extends CIUnitTestCase
     private string $originalSavePath;
     private string $originalSidBits;
     private string $originalSidLength;
+    private bool $registeredFaultyStream = false;
 
     protected function setUp(): void
     {
         parent::setUp();
 
         if (! in_array('faulty', stream_get_wrappers(), true)) {
             stream_wrapper_register('faulty', FaultyStream::class);
+            $this->registeredFaultyStream = true;
         }
 
         $this->originalSavePath  = (string) ini_get('session.save_path');
@@ -63,6 +66,11 @@ protected function tearDown(): void
 
         FaultyStream::reset();
 
+        if ($this->registeredFaultyStream && in_array('faulty', stream_get_wrappers(), true)) {
+            stream_wrapper_unregister('faulty');
+            $this->registeredFaultyStream = false;
+        }
+
         $this->removeDirectory($this->tempPath);
     }
 
@@ -226,6 +234,7 @@ public function testOpenThrowsForInvalidSavePath(): void
         $this->withSuppressedErrors(fn (): bool => $handler->open($this->tempPath . '/blocker/sub', $this->sessionName));
     }
 
+    #[RequiresOperatingSystem('Linux|Darwin')]
     public function testOpenThrowsForWriteProtectedSavePath(): void
     {
         $dir = $this->tempPath . '/readonly';
@@ -517,6 +526,7 @@ public function testGCWhenSavePathMissing(): void
         $this->assertLogContains('debug', "Session: Garbage collector couldn't list files under directory");
     }
 
+    #[RequiresOperatingSystem('Linux|Darwin')]
     public function testGCWhenDirectoryCannotBeOpened(): void
     {
         $dir = $this->tempPath . '/unreadable';