test: apply rector fixes to FaultyStream

Author: gr8man

rector.php

@@ -24,6 +24,7 @@
 use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedConstructorParamRector;
 use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodRector;
 use Rector\DeadCode\Rector\MethodCall\RemoveNullArgOnNullDefaultParamRector;
+use Rector\DeadCode\Rector\Property\RemoveDefaultValueFromAssignedPropertyRector;
 use Rector\EarlyReturn\Rector\Foreach_\ChangeNestedForeachIfsToEarlyContinueRector;
 use Rector\EarlyReturn\Rector\If_\ChangeIfElseValueAssignToEarlyReturnRector;
 use Rector\EarlyReturn\Rector\If_\RemoveAlwaysElseRector;
@@ -99,6 +100,9 @@
             __DIR__ . '/system/HTTP/Response.php',
         ],
 
+        // Keep property defaults for backward compatibility.
+        RemoveDefaultValueFromAssignedPropertyRector::class,
+
         // Exclude test file because `is_cli()` is mocked and Rector might remove needed parameters.
         RemoveExtraParametersRector::class => [
             __DIR__ . '/tests/system/Debug/ToolbarTest.php',

tests/_support/Session/FaultyStream.php

@@ -52,7 +52,7 @@ public static function reset(): void
         self::$failWrite = false;
     }
 
-    public function stream_open(string $path, string $mode, int $options, ?string &$openedPath): bool
+    public function stream_open(): bool
     {
         $this->stream = fopen('php://temp', 'c+b');
 
@@ -69,9 +69,9 @@ public function stream_write(string $data): false|int
         return self::$failWrite ? false : fwrite($this->stream, $data);
     }
 
-    public function stream_lock(int $operation): bool
+    public function stream_lock(): bool
     {
-        return self::$failLock ? false : true;
+        return ! self::$failLock;
     }
 
     public function stream_close(): void
@@ -110,7 +110,7 @@ public function stream_stat(): array
      *
      * @return array<string, int>
      */
-    public function url_stat(string $path, int $flags): array
+    public function url_stat(): array
     {
         return [
             'dev'     => 0,