Feat/dotnet install#220
Open
Manuel-Technologies wants to merge 2 commits intocalchiwo:mainfrom
Open
Conversation
|
@Manuel-Technologies is attempting to deploy a commit to the calebwodi Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Add .NET Global Tool Distribution Support
Summary
This PR adds
.NETglobal tool support for ExplainThisRepo so users can install and run the CLI withdotnet tool install -g ExplainThisRepo.The contribution keeps the existing architecture intact:
.NETacts as a thin launcher and distribution pathWhy
ExplainThisRepo already supports:
pipfor the Python packagenpmfor a prebuilt binary distributionThis PR adds a first-class installation path for
.NETusers without moving business logic into C#.That means:
What Changed
1. Added a C# launcher
The launcher in
dotnet_version/Program.cs:2. Added Make targets for .NET packaging
The
Makefilenow includes:build-dotnetpack-dotnetIt also cleans generated
.NETbuild artifacts duringmake clean.3. Updated installation documentation
The
README.mdnow documents.NET Toolinstallation as an official install option.Design Notes
This PR intentionally does not move application logic into
.NET.The C# layer is only a launcher. It mirrors the role already played by the Node distribution path:
This keeps the project aligned with the contribution guidelines and current architecture.
How To Test
Local verification
Build the .NET package:
Run the launcher after packaging and verify it forwards arguments correctly:
Expected behavior
Reviewer Notes
Makefile, where upstream cleanup/build changes were combined with the new.NETtargets.Files of Interest
dotnet_version/Program.csdotnet_version/ExplainThisRepo.csprojMakefileREADME.md.github/workflows/release-binaries.yml.gitignoreSuggested PR Body