await next in hono error handler middleware - #2735
Merged
Merged
Conversation
|
| Minified | Minfied + Gzipped | |
|---|---|---|
| Before | 51.76 kB |
15.30 kB |
| After | 51.76 kB |
15.30 kB |
| ± | No change | No change |
code coverage diff
| Ok | File | Lines | Branches | Functions | Statements |
|---|---|---|---|---|---|
| 🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-hono/src/hono.js | 90% (-4.11%) |
75% (-15%) |
100% (+0%) |
85.71% (-8.57%) |
Total:
| Lines | Branches | Functions | Statements |
|---|---|---|---|
| 84.93%(-0.02%) | 77.1%(-0.06%) | 85.17%(+0%) | 84.17%(-0.06%) |
gingerbenw
force-pushed
the
gingerbenw/hono-async-await
branch
from
April 23, 2026 08:45
b606807 to
521b9db
Compare
gingerbenw
force-pushed
the
gingerbenw/hono-async-await
branch
from
April 24, 2026 14:38
a175c8d to
2c37bcd
Compare
gingerbenw
commented
Apr 24, 2026
gingerbenw
commented
Apr 24, 2026
gingerbenw
commented
Apr 24, 2026
gingerbenw
commented
Apr 24, 2026
gingerbenw
marked this pull request as ready for review
April 24, 2026 15:45
gingerbenw
changed the title
SB-priyankap
approved these changes
May 6, 2026
This was referenced Jul 3, 2026
Merged
Merged
Closed
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Updates the Hono plugin’s error-handling middleware to properly await next() and adds/adjusts integration tests and fixtures to cover async behavior, non-Error throws, and request-body parsing.
Changeset
@bugsnag/plugin-honoerror handler to await next() and handle thrown non-Error values.Testing