Skip to content

Update assertions on freeDisk on iOS#2723

Merged
gingerbenw merged 1 commit intonextfrom
PLAT-11345/free-disk-tests
Apr 13, 2026
Merged

Update assertions on freeDisk on iOS#2723
gingerbenw merged 1 commit intonextfrom
PLAT-11345/free-disk-tests

Conversation

@gingerbenw
Copy link
Copy Markdown
Member

@gingerbenw gingerbenw commented Apr 10, 2026

Goal

Add null check for freeDisk on iOS to existing tests - this value is no longer automatically set on iOS.

This could be manually set and asserted against in the scenario, i.e.:

[Bugsnag.instance.configuration.device setValue:@(1234567) forKey:@"freeDisk"];

but does not feel like a useful test.

@gingerbenw gingerbenw changed the title test: update assertions on freeDisk which will always be null on iOS Update assertions on freeDisk which will always be null on iOS Apr 10, 2026
@github-actions
Copy link
Copy Markdown

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 51.76 kB 15.30 kB
After 51.76 kB 15.30 kB
± No change No change

code coverage diff

Coverage values did not change👌.

Total:

Lines Branches Functions Statements
0%(+0%) 0%(+0%) 0%(+0%) 0%(+0%)

Generated by 🚫 dangerJS against c1945bf

@gingerbenw gingerbenw changed the title Update assertions on freeDisk which will always be null on iOS Update assertions on freeDisk Apr 10, 2026
@gingerbenw gingerbenw requested a review from a team April 10, 2026 16:39
@gingerbenw gingerbenw marked this pull request as ready for review April 10, 2026 16:39
@gingerbenw gingerbenw changed the title Update assertions on freeDisk Update assertions on freeDisk on iOS Apr 10, 2026
@gingerbenw gingerbenw merged commit 968565d into next Apr 13, 2026
56 checks passed
@gingerbenw gingerbenw deleted the PLAT-11345/free-disk-tests branch April 13, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants