Skip to content

Bump CUID version and replace validation #2705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SB-priyankap wants to merge 1 commit into from
+7 −7
Closed

Bump CUID version and replace validation #2705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"author": "Bugsnag",
"license": "MIT",
"dependencies": {
"@bugsnag/cuid": "^3.0.0",
"@bugsnag/cuid": "^3.2.1",
"@bugsnag/safe-json-stringify": "^6.0.0",
"error-stack-parser": "^2.0.3",
"iserror": "^0.0.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/in-flight/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"author": "Bugsnag",
"license": "MIT",
"dependencies": {
"@bugsnag/cuid": "^3.0.0"
"@bugsnag/cuid": "^3.2.1"
},
"devDependencies": {
"@bugsnag/core": "^8.8.0"
Expand Down
8 changes: 4 additions & 4 deletions packages/plugin-browser-device/device.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
const assign = require('@bugsnag/core/lib/es-utils/assign')
const BUGSNAG_ANONYMOUS_ID_KEY = 'bugsnag-anonymous-id'
const cuid = require('@bugsnag/cuid')

const getDeviceId = (win) => {
try {
const storage = win.localStorage

let id = storage.getItem(BUGSNAG_ANONYMOUS_ID_KEY)

// If we get an ID, make sure it looks like a valid cuid. The length can
// fluctuate slightly, so some leeway is built in
if (id && /^c[a-z0-9]{20,32}$/.test(id)) {
// If we get an ID, make sure it looks like a valid cuid

if (id && cuid.isCuid(id)) {
return id
}

const cuid = require('@bugsnag/cuid')
id = cuid()

storage.setItem(BUGSNAG_ANONYMOUS_ID_KEY, id)
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-browser-device/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"author": "Bugsnag",
"license": "MIT",
"dependencies": {
"@bugsnag/cuid": "^3.0.0"
"@bugsnag/cuid": "^3.2.1"
},
"devDependencies": {
"@bugsnag/core": "^8.8.0"
Expand Down
Loading