Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .buildkite/basic/react-native-ios-full-pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ steps:
command:
- --app=/app/features/fixtures/generated/old-arch/{{matrix}}/output/reactnative.ipa
- --farm=bb
- --device=IOS_15
- --device=IOS_17|IOS_18|IOS_26
- --fail-fast
- --no-tunnel
- --aws-public-ip
Expand Down Expand Up @@ -199,7 +199,7 @@ steps:
command:
- --app=/app/features/fixtures/generated/new-arch/{{matrix.reactnative}}/output/reactnative.ipa
- --farm=bb
- --device=IOS_15
- --device=IOS_17|IOS_18|IOS_26
- --fail-fast
- --no-tunnel
- --aws-public-ip
Expand Down Expand Up @@ -253,7 +253,7 @@ steps:
command:
- --app=/app/features/fixtures/generated/react-native-navigation/old-arch/{{matrix}}/output/reactnative.ipa
- --farm=bb
- --device=IOS_15
- --device=IOS_17|IOS_18|IOS_26
- --fail-fast
- --no-tunnel
- --aws-public-ip
Expand Down Expand Up @@ -295,7 +295,7 @@ steps:
# command:
# - --app=/app/features/fixtures/generated/react-native-navigation/new-arch/{{matrix}}/output/reactnative.ipa
# - --farm=bb
# - --device=IOS_15
# - --device=IOS_17|IOS_18|IOS_26
# - --fail-fast
# - --no-tunnel
# - --aws-public-ip
Expand Down
2 changes: 1 addition & 1 deletion .buildkite/basic/react-native-ios-pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ steps:
command:
- --app=/app/features/fixtures/generated/new-arch/{{matrix}}/output/reactnative.ipa
- --farm=bb
- --device=IOS_15
- --device=IOS_17|IOS_18|IOS_26
- --fail-fast
- --no-tunnel
- --aws-public-ip
Expand Down
18 changes: 10 additions & 8 deletions test/react-native/features/native-stack.feature
Original file line number Diff line number Diff line change
Expand Up @@ -129,22 +129,23 @@ Scenario: Handled native promise rejection with native stacktrace

# the javascript part follows
# On 0.74+ New Arch there is no JS stacktrace - see PLAT-12193
And the event "exceptions.0.stacktrace.20.columnNumber" equals the version-dependent string:
# We're check the method: asyncGeneratorStep
And the event "exceptions.0.stacktrace.21.columnNumber" equals the version-dependent string:
| arch | version | value |
| new | 0.72 | @not_null |
| new | default | @skip |
| old | default | @not_null |
And the event "exceptions.0.stacktrace.20.file" equals the version-dependent string:
And the event "exceptions.0.stacktrace.21.file" equals the version-dependent string:
| arch | version | value |
| new | 0.72 | @not_null |
| new | default | @skip |
| old | default | @not_null |
And the event "exceptions.0.stacktrace.20.lineNumber" equals the version-dependent string:
And the event "exceptions.0.stacktrace.21.lineNumber" equals the version-dependent string:
| arch | version | value |
| new | 0.72 | @not_null |
| new | default | @skip |
| old | default | @not_null |
And the event "exceptions.0.stacktrace.20.type" equals the version-dependent string:
And the event "exceptions.0.stacktrace.21.type" equals the version-dependent string:
| arch | version | value |
| new | 0.72 | @null |
| new | default | @skip |
Expand Down Expand Up @@ -173,22 +174,23 @@ Scenario: Unhandled native promise rejection with native stacktrace

# the javascript part follows
# On 0.74+ New Arch there is no JS stacktrace - see PLAT-12193
And the event "exceptions.0.stacktrace.20.columnNumber" equals the version-dependent string:
# We're check the method: asyncGeneratorStep
And the event "exceptions.0.stacktrace.21.columnNumber" equals the version-dependent string:
| arch | version | value |
| new | 0.72 | @not_null |
| new | default | @skip |
| old | default | @not_null |
And the event "exceptions.0.stacktrace.20.file" equals the version-dependent string:
And the event "exceptions.0.stacktrace.21.file" equals the version-dependent string:
| arch | version | value |
| new | 0.72 | @not_null |
| new | default | @skip |
| old | default | @not_null |
And the event "exceptions.0.stacktrace.20.lineNumber" equals the version-dependent string:
And the event "exceptions.0.stacktrace.21.lineNumber" equals the version-dependent string:
| arch | version | value |
| new | 0.72 | @not_null |
| new | default | @skip |
| old | default | @not_null |
And the event "exceptions.0.stacktrace.20.type" equals the version-dependent string:
And the event "exceptions.0.stacktrace.21.type" equals the version-dependent string:
| arch | version | value |
| new | 0.72 | @null |
| new | default | @skip |
Expand Down
9 changes: 2 additions & 7 deletions test/react-native/features/steps/react-native-steps.rb
Original file line number Diff line number Diff line change
Expand Up @@ -63,16 +63,11 @@ def wait_for_app_state(expected_state)

When('I relaunch the app after a crash') do
state = wait_for_app_state :not_running
# TODO: Really we should be using terminate_app/activate_app with the newer Appium client,
# but for some reason they seem to make some scenarios flaky (presumably due to the
# nature of how/when they close the app).
manager = Maze::Api::Appium::AppManager.new
if state != :not_running
manager.close
# manager.terminate
manager.terminate
end
manager.launch
# manager.activate
manager.activate
end

When('I clear any error dialogue') do
Expand Down